[shubhamkapoor01]

Related issue: Resolves #55105

When the server sends an error frame during a live report (for example a pubsub error), fleetctl printed "unknown msg type error". It now shows the server's message. This doesn't change when fleetctl stops or what it exits with; happy to add that if you'd like.

Checklist for submitter

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
• Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.
• Timeouts are implemented and retries are limited to avoid infinite loops

Testing

• Added/updated automated tests
• QA'd all new/changed functionality manually

AI

AI: Claude Code (claude-opus-5-5)

Summary by CodeRabbit

• Bug Fixes
  • fleetctl now displays the server’s error message when a live report fails instead of a generic unknown-error message.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: fleetdm/fleet
• Branch: main
• File: .coderabbit.yaml
• Commit: 3265a74
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 0106422d-2e0f-482b-bc4e-839c212de097

Commits

Reviewing files that changed from the base of the PR and between 3265a74 and 601b5b0.

Files selected for processing: 3

• changes/55105-fleetctl-live-query-errors
• server/service/client_live_query.go
• server/service/client_live_query_test.go

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The live-query WebSocket handler now recognizes error messages. It decodes the message data as a string, uses the raw data if decoding fails, and sends the result through the error channel. A test verifies that the channel receives the server’s error message. A changelog entry records the change.

Priority: Low

Severity of issue fixed: Low

Merge Risk: Minimal · up to 601b5

Live reports now display the inspected server error messages. No issue requiring a change before merge was found.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title "Show the server's error message for live report error frames" matches the main change. The PR makes fleetctl print the server's error message when a live report fails, instead of the generi…
Description check		The description follows the template structure. It links the issue (Resolves #55105) and explains the change and its limits, namely that stop behavior and exit status are unchanged. The changes-file, …
Linked Issues check		Issue #55105 requires fleetctl to display the server message from live-query error frames instead of unknown msg type error. The change handles type: "error", decodes the message data, falls bac…
Out of Scope Changes check		The changed production code, automated test, and changelog directly support issue #55105. The changes do not add unrelated behavior or unrelated files.

Full details: Title check

Explanation

The title "Show the server's error message for live report error frames" matches the main change. The PR makes fleetctl print the server's error message when a live report fails, instead of the generic "unknown msg type error". The title is specific and clear, and it describes the primary change from the developer's view.

Full details: Description check

Explanation

The description follows the template structure. It links the issue (Resolves #55105) and explains the change and its limits, namely that stop behavior and exit status are unchanged. The changes-file, automated-test, and AI sections are checked. The description does not complete the manual QA item, which the author left unchecked. The Frontend section and the other conditional sections are omitted or unchecked, which is acceptable because they do not apply to this change. The description is mostly complete.

Full details: Linked Issues check

Explanation

Issue #55105 requires fleetctl to display the server message from live-query error frames instead of unknown msg type error. The change handles type: "error", decodes the message data, falls back to raw data when decoding fails, and sends the message to the existing error path. TestLiveQueryErrorFrame verifies propagation of pubsub error: boom. The changelog documents the user-visible fix. The PR does not change stop behavior or exit status, which matches the stated scope.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.66%. Comparing base (237bd08) to head (601b5b0).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
server/service/client_live_query.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56708   +/-   ##
=======================================
  Coverage   77.65%   77.66%           
=======================================
  Files        4394     4394           
  Lines      273738   273796   +58     
  Branches    16072    16072           
=======================================
+ Hits       212578   212634   +56     
- Misses      60973    60975    +2     
  Partials      187      187           

Flag	Coverage Δ
backend	78.86% <75.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[lucasmrod]

LGTM.

Thanks for the contribution @shubhamkapoor01!