Repository navigation
fix(agents): clarify model defaults and provider actions - #1177
Conversation
Closed provider and agent model/thinking pickers now lead with where an unpinned value comes from. Provider settings say "Recommended · X" for the provider's catalog recommendation; an agent inheriting from its provider says "Default · X", including when that default is a saved provider preference. Explicit choices show only their value. Model catalog loading now reads "Loading models…" inside the disabled picker instead of a separate subtitle, and a disabled preference select keeps its row label readable. Claude Code's provider dialog moves Cancel and its primary action into the shared right-aligned ProviderDialogActions footer, matching Codex; Cancel still stops a running setup and never saves a draft. Co-authored-by: Princess Donut <0366ccd5ee09c2779a9d6bd6683daa17c16a508a51f6a7e7314018dab8fdc49b@buzz.block.builderlab.xyz> Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Document that the trigger owns unavailability, and cover the separate enabled label and disabled control contract. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Assert that the closed settings picker shows the inherited model once, without a duplicated Provider default prefix. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Show the model value in subtle card chips while retaining the inherited source in their title and menu. Preserve source-first labels in settings and creation controls. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
|
🤖 Carl: Follow-up to Princess Donut's requested review of her UI port at Addressed the three recommended improvements: Verified published head: The card captures use the real desktop development app with the documented broker-backed identity mode and establish rendering only. Final-head reviewer agreement, the remaining visual/keyboard matrix, and human/native identity acceptance are still pending. Deferred the optional loading-copy/icon refinements and pre-existing setup-focus issue. No private coordination link was added to the public body. The PR stays draft. |
Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
|
🤖 Carl (AI agent): restored the visible Default label on agent cards in All 15 ModelPicker tests pass, including changed inherited defaults without saving a pin and plain explicit pins. The card regression fails against the previous value-only implementation. Mandatory pre-push checks passed. The PR description now includes a fresh native control crop from this head, verified to render; it replaces the earlier value-only card example. Capture used the actual desktop development app with broker-backed identity mode and establishes layout, not native identity acceptance. The PR remains draft. The current head has not received another review; the remaining visual matrix and human acceptance are pending. |
Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
|
🤖 Carl (AI agent): agent cards now render model · Default as plain inline text at All 22 tests in the ModelPicker and Select files pass, covering inherited-default updates, explicit pins, loading and menu selection. The design viewer typecheck/build and mandatory pre-push checks pass. The PR includes verified native captures at 984px and 1364px window widths from the real desktop development app with broker-backed identity mode; they establish layout, not native identity acceptance. The PR remains draft. Final-head review, the remaining visual/keyboard matrix and human acceptance are pending. |
Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
|
🤖 Carl implemented tho’s follow-up presentation feedback at Validation: all 57 Codex/Claude tests pass with the final copy; mandatory pre-push type/related-unit, design, Rust Clippy and destination checks pass. Fresh native Codex/Claude captures at this head are in the description and Buzz; no defaults were saved. The unchanged card captures remain attributed to This is a repair record, not an independent review or human acceptance. Final-head review, the remaining visual/keyboard matrix, and human acceptance remain pending; the PR stays draft. |
Integrate main at 7ceb46d, the base tested by the failing CI run. Preserve the newer Codex behavior regressions and align four model-label expectations with the approved value-first Default presentation. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Close and discard the defaults draft while Claude is ready. Only stop a setup step when its progress is visible. Cover a held startup update alongside draft cancellation. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@buzz.block.builderlab.xyz> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
|
🤖 @kalvinnchau Fixed at The regression runs the mounted provider dialog during a held startup install and verifies the close callback, unchanged saved defaults, and no installer kill. It fails before the handler fix. All 51 tests in the complete Claude tabs/setup files pass; mandatory pre-push type/related-unit, design, Rust Clippy and destination checks pass. Hosted CI for this head is pending. This validation uses the real setup/controller and dialog with a fixture host; no native download was forced. |
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord’s automated source review via Wes’s account. No actionable findings; no changes requested (9/10 for minimalness, ownership and source correctness).
Reviewed inherited versus explicit model choices, loading states, the shared Select suffix, and Claude’s Cancel/Save footer—including preserving the background update when discarding defaults. The public description and all four attached screenshots were inspected.
Head fe1df930e255c2a6e5e08c3690e084399de11102; base 7ceb46de6c37f5685279f8e1e2812084198e8169. Source-only: no code, tests, builds or app execution, and current CI was not assessed. Attached captures are from the earlier revisions identified in the PR; final-head native behavior, keyboard/retry focus, both themes, enlarged text and human acceptance remain unverified. COMMENT only, not merge approval.
…ui-polish * buzz-app/main: (43 commits) Unify file attachment cards and file-type artwork (#1220) feat(agents): start agents from relay-synced config copies (#1185) render shared sessions as attachment cards (#1217) fix(channels): keep other channels' permission reads alive across a delete (#1245) feat(channels): mark temporary channels in the sidebar (#1249) test(browser): fix six intermittent browser test failures and a composer caret bug (#1239) Close channel tabs together and make tab shortcuts predictable (#1154) Make message retry controls compact and accessible (#1221) fix(messages): end deferred composer focus on any focus move; stabilise hover-preview probe (#1244) fix(messages): keep restored-channel focus off the composer (#1243) fix(me): record reads in Solo chats opened from the sidebar (#1183) feat(inbox): archive or restore the open conversation with Control-Command-A (#1181) fix: keep panel divider dragging responsive (#1067) feat(agents): find people for agents through the relay's name-only profile search (#1124) fix(agents): explain why Create agent is disabled (#1232) feat(agents): run up to 8 Interests at once for every agent type (#1100) fix(codex): set up Codex from the agent creation card, as Claude does (#1231) Shrink the thread loading mark by a third (#1214) feat(agents): plugins add tools to every agent session (#1216) fix(sidebar): re-measure every drop target when a section resizes mid-drag (#1230) ... Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
…ui-polish * buzz-app/main: test(agents): fix main typecheck — add effort to Goose fixture (#1262) fix(messages): reject unclaimed file and link drops app-wide (#1075) feat(channels): create and read system channels (#965) Refine message layout and bubble reading widths (#1218) feat(goose): save a Thinking level and match the Claude/Codex profile (#1250) Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
…ui-polish * buzz-app/main: fix(agents): show native agent pictures in the Solo agent picker (#1258) Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
…ui-polish * buzz-app/main: test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
kalvinnchau
left a comment
There was a problem hiding this comment.
🤖 Approved. Nonblocking P3: Goose Thinking omits the inherited-value Default suffix; the Goose card also retains the older label format. Native provider-flow acceptance remains unverified.
* origin/main: chore(deps): upgrade vitest to 5.0.4 (#1272) feat(plugins): reload folder plugins from the CLI (#1265) add channel shared sessions discovery and retrieval (#1254) polish Solo activity layout and fold previous steps (#1257) fix(agents): clarify model defaults and provider actions (#1177) Signed-off-by: John Tennant <jtennant@block.xyz> # Conflicts: # src/bundled/channels/index.tsx
…lation * origin/main: (139 commits) feat(agents): let plugins read each agent's sessions (#1111) chore(deps): upgrade vitest to 5.0.4 (#1272) feat(plugins): reload folder plugins from the CLI (#1265) add channel shared sessions discovery and retrieval (#1254) polish Solo activity layout and fold previous steps (#1257) fix(agents): clarify model defaults and provider actions (#1177) fix(messages): stop the channel timeline jumping back when agents or search read old messages (#1256) Add Close other tabs to the tab menu (#1127) chore(deps): upgrade virtua to 0.53.5 and port its scroll patch (#1269) Auto-tag Berd drafts with a chosen default agent (#1139) test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) fix(agents): show native agent pictures in the Solo agent picker (#1258) test(agents): fix main typecheck — add effort to Goose fixture (#1262) fix(messages): reject unclaimed file and link drops app-wide (#1075) feat(channels): create and read system channels (#965) Refine message layout and bubble reading widths (#1218) ...
Inherited model choices did not clearly show where their values came from, and catalog loading appeared outside the input.
Provider settings, agent settings, creation and cards show value · Default for default choices, including saved provider preferences inherited by agents. All labels use plain inline text, with the value first. The model name may ellipsize on narrow cards while Default stays visible; explicit pins show only their model. The full choice remains in the title and menu. Loading appears inside the disabled picker, and Claude’s dialog uses the shared Cancel → Save defaults footer. Cancel discards the settings draft without stopping a background update; it stops setup when the setup progress is visible.
The shared Select keeps setting labels readable whenever its control is disabled, including during saving or when unavailable. Goose’s inherited model label avoids a duplicated “Provider default” prefix.
Validation: All 51 tests in the complete Claude tabs/setup files pass with the Cancel repair at
fe1df930e; the new regression fails before the fix. It exercises the mounted provider dialog during a held startup update and verifies closing, unchanged saved defaults, and an uninterrupted download. Mandatory pre-push type/related-unit, design, Rust Clippy and destination checks pass at this head. The preceding CI run passed atc60e29498; hosted checks at the updated head are pending. The provider captures below remain attributed tob8cb0eafd; the unchanged card layout was captured at3145ecf51. Final-head review, the remaining visual/keyboard matrix, and human acceptance are pending.Native screenshots
Codex provider defaults:
Claude provider defaults:
Agent cards at two widths
Actual desktop development app at
3145ecf51, using broker-backed identity mode. Controls are cropped to exclude agent names and workspace content. These captures establish layout, not native identity acceptance.At a 1364px window width (approximately 234.7px cards), the model and Default text fit naturally on one line:
At a 984px window width (approximately 196.7px cards), only the model name truncates: