feat(goose): show goose and provider marks on agent cards by salman1993 · Pull Request #1260 · block/buzz-app

salman1993 · 2026-10-16T16:26:48Z

Goose agent cards now show the Goose mark, like Claude and Codex cards show theirs. When Buzz has a mark for the agent's provider, it appears after the Goose mark. The Provider picker shows the same provider marks.

What changed

Card pill: Goose's model control on agent cards uses the same filled pill as the Claude and Codex model pickers (it was a plain ghost button before). It leads with the Goose mark, then the provider's mark. With no provider set, it uses goose's default provider.
Provider picker: the Provider field and its options show provider marks. This covers the New agent dialog, the card's Provider and model dialog, and the Settings row.
Providers with a mark: Anthropic (the Claude mark), OpenAI, Google, Databricks and AWS Bedrock. Any other provider shows no provider mark.
No hover tooltip: the pill dropped its "Choose provider and model" tooltip. Like the Codex pill, it puts only the full label in a native title.
Icons: adds GoogleLogoIcon, DatabricksLogoIcon and AwsLogoIcon from Tabler's brand set to the icons gateway.

Also in this PR

main doesn't typecheck right now: #1185 added the GOOSE_LOCAL fixture in launch-boundary.test.ts, and #1250 later made goose's effort required. The second commit adds effort: "" to the fixture. The pre-push hook blocks every push until that's fixed.

Testing

New unit test in tabs.test.tsx: the card shows the Goose and Databricks marks, the Provider list shows a mark for Databricks and none for OpenRouter, and choosing OpenRouter leaves only the Goose mark. It fails without the change.
Goose and agents tests pass (194), typecheck is clean, and design:check passes.
Rendered the real card control and Provider dialog in the browser against a fake goose, in dark and light themes, at the app's card width. Before the tooltip change, Salman tried it in the desktop app with real agents.

Notes

Icon choices belong to the designer. The three new marks are Tabler brand icons, imported the same way as the existing OpenAI mark.
With two marks, long model names get cut off with "…" sooner on Goose cards than on Claude or Codex cards.

🤖 Generated with Claude Code

Goose cards now use the same subtle pill as Claude and Codex, led by the Goose mark and, for Anthropic, OpenAI, Google, Databricks and AWS Bedrock, the provider's mark. The Provider picker shows the same marks. Other providers show no provider mark. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>

…ons-a89821 Signed-off-by: Salman Mohammed <smohammed@squareup.com>

#1250 made `effort` part of goose's config after #1185 wrote this fixture, so main's typecheck fails without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>

chatgpt-codex-connector · 2026-10-16T16:27:08Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T16:30:00.051753Z	`bd991b6`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Main fails typecheck since #1250 made effort required and #1185 added this fixture without it. Same one-line fix as in #1257 and #1260. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>

salman1993 · 2026-10-16T16:31:10Z

before and after:

kalvinnchau

🤖 Review submitted by Hobbes, an AI agent, at the operator’s direction. Reviewed bd991b6 against merge base ccd1be5.

No proven functional or security defects in the four-file diff. Optional visual improvement: src/bundled/goose/tabs.tsx:227 supplies leading icons only for mapped providers, so OpenRouter and ‘From goose config’ labels have different indentation. A fallback icon would align the options. This is source-derived, not browser-verified.

Typecheck, design checks/builds and diff whitespace checks passed. Full Vitest: 9,952 passed, 62 failed, 74 skipped; neither changed test file appears in the failure list. Full Node integration: 222 passed, 3 failed, 3 skipped; failures were fixture timeouts. Failures remain unclassified, with no baseline comparison; some checks overlapped. Approval does not establish that these failures predate this change.

Browser validation remains incomplete: the prescribed web startup accessed Keychain, conflicting with the review constraints, and was stopped before browser navigation. Goose registration is also native-only. Theme/width/enlarged-text layouts, keyboard/focus, settings save/reload, and real Goose/provider flows remain unverified. No Rust/root composite run.

Approving as explicitly requested by the operator with these validation gaps disclosed.

New agent's Model field and the library card show one pill, matching goose's (#1260): the Pi mark, the provider's mark when Buzz has one (Anthropic, OpenAI), then the model. The pill opens the provider and model dialog, which replaces the separate Provider… button, and the card's control is centered again. The Provider select in the dialog and in Identity shows the same marks. Choosing another model from the card keeps the saved Thinking level only if that model has it. CreateModelChoices loses the `action` slot Pi had added, so it matches main again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>

…ui-polish * buzz-app/main: test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) Signed-off-by: Taylor Ho <taylorkmho@gmail.com>

…lation * origin/main: (139 commits) feat(agents): let plugins read each agent's sessions (#1111) chore(deps): upgrade vitest to 5.0.4 (#1272) feat(plugins): reload folder plugins from the CLI (#1265) add channel shared sessions discovery and retrieval (#1254) polish Solo activity layout and fold previous steps (#1257) fix(agents): clarify model defaults and provider actions (#1177) fix(messages): stop the channel timeline jumping back when agents or search read old messages (#1256) Add Close other tabs to the tab menu (#1127) chore(deps): upgrade virtua to 0.53.5 and port its scroll patch (#1269) Auto-tag Berd drafts with a chosen default agent (#1139) test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) fix(agents): show native agent pictures in the Solo agent picker (#1258) test(agents): fix main typecheck — add effort to Goose fixture (#1262) fix(messages): reject unclaimed file and link drops app-wide (#1075) feat(channels): create and read system channels (#965) Refine message layout and bubble reading widths (#1218) ...

salman1993 and others added 3 commits October 16, 2026 12:22

Merge remote-tracking branch 'origin/main' into claude/goose-agent-ic…

0ca47e9

…ons-a89821 Signed-off-by: Salman Mohammed <smohammed@squareup.com>

test(agents): give the synced goose fixture a thinking level

bd991b6

#1250 made `effort` part of goose's config after #1185 wrote this fixture, so main's typecheck fails without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Salman Mohammed <smohammed@squareup.com>

salman1993 requested a review from a team as a code owner October 16, 2026 16:26

kalvinnchau approved these changes Oct 16, 2026

View reviewed changes

loganj mentioned this pull request Oct 16, 2026

fix(messages): stop the channel timeline jumping back when agents or search read old messages #1256

Merged

salman1993 mentioned this pull request Oct 16, 2026

feat(pi): add the Pi agent type on Pi durable #1103

Closed

salman1993 merged commit 30ad001 into main Oct 16, 2026
59 of 61 checks passed

salman1993 deleted the claude/goose-agent-icons-a89821 branch October 16, 2026 17:13

wesbillman mentioned this pull request Oct 17, 2026

Improve AI defaults and add Goose configuration #1266

Merged

Navigation Menu

Repository navigation

feat(goose): show goose and provider marks on agent cards - #1260

feat(goose): show goose and provider marks on agent cards#1260
salman1993 merged 3 commits into
mainfrom
claude/goose-agent-icons-a89821

salman1993 commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

salman1993 commented Oct 16, 2026

Uh oh!

kalvinnchau left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

salman1993 commented Oct 16, 2026

What changed

Also in this PR

Testing

Notes

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

salman1993 commented Oct 16, 2026

Uh oh!

kalvinnchau left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading