Repository navigation
test: delete styling, markup and call-count trivia tests - #1255
Merged
Merged
Conversation
Phase 1 of the test-suite slimming. Removes tests that only freeze paint (radius, RGB, margins, fonts), markup/class/data-attribute shape, render or call counts on mocks, harness self-checks and documentation inventories. Behavior they carried is either already covered by a named journey or kept in a trimmed form. Items whose "covered elsewhere" claim did not hold on inspection were kept. No production code changes. Co-authored-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Court review of the trivia cuts found five cases that were the only falsifier for real behavior. Restore them in compact form: - a lifetime save retired by its visit or unmount while signing is held never publishes, and parent-linked sessions stay ineligible - oversized originals are never explicitly decoded for avatar warming - adding a custom emoji rebuilds the own set from a fresh relay read and fails closed when that read fails - the account avatar and Availability control keep 4.5:1 contrast through hover and press in both themes - the thinking badge reverses mid-morph and settles at once under reduced motion Co-authored-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
carl/test-trivia-cuts
branch
from
October 16, 2026 16:51
9affc70 to
cb32e0b
Compare
wesbillman
marked this pull request as ready for review
October 16, 2026 17:18
baxen
approved these changes
Oct 16, 2026
kalvinnchau
approved these changes
Oct 16, 2026
tellaho
added a commit
that referenced
this pull request
Oct 16, 2026
…ui-polish * buzz-app/main: test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 16, 2026
…lation * origin/main: (139 commits) feat(agents): let plugins read each agent's sessions (#1111) chore(deps): upgrade vitest to 5.0.4 (#1272) feat(plugins): reload folder plugins from the CLI (#1265) add channel shared sessions discovery and retrieval (#1254) polish Solo activity layout and fold previous steps (#1257) fix(agents): clarify model defaults and provider actions (#1177) fix(messages): stop the channel timeline jumping back when agents or search read old messages (#1256) Add Close other tabs to the tab menu (#1127) chore(deps): upgrade virtua to 0.53.5 and port its scroll patch (#1269) Auto-tag Berd drafts with a chosen default agent (#1139) test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) fix(agents): show native agent pictures in the Solo agent picker (#1258) test(agents): fix main typecheck — add effort to Goose fixture (#1262) fix(messages): reject unclaimed file and link drops app-wide (#1075) feat(channels): create and read system channels (#965) Refine message layout and bubble reading widths (#1218) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of slimming the test suite. Tests are 333k lines against 248k of production code, and Playwright takes 81% of CI runner time. This PR removes tests that only freeze presentation or implementation detail:
No production code changes. Net −4,199 lines across 51 files.
How cuts were chosen
Candidates came from a read-only audit. Before each delete:
About a third of the candidates were kept this way, for example:
agents/tabsAgentAvatarprepared.test.ts:315(revocation)view-keyDeliveryNoticeMessageTimestampencode-webpAgent review then found five deleted cases that were the only falsifier for real behavior. The second commit restores them in compact form:
sessions/SessionLifetime.test.tsx, trimmed to these cases with the real details ownerrelay/media.test.ts, a two-row tableInfinityfails the oversized rowrelay/emoji.test.ts, restored unchangedtests/browser/profile-contrast.spec.mjs, the contrast half ofprofile-avatar-gapviewer.spec.tsBrowser cases removed
Each row gives the browser-only justification it had and what now covers it:
channel-activity-corners: popup inset radiithread-unread.spec"thread buttons show observed unread…"scrollbar-polish: scrollbar colour, width and gutterlayout.spec:925–970app-style-order: hover colour after token injectionglobal-search.spec"search arrows traverse…"profile-avatar-gap: cutout paint and theme highlightssettings.spec"avatar Settings access…" andaccount-profile.spec. Contrast is kept inprofile-contrast.specquote-styling,message-content-polish,message-delivery-polish,profiles-appearanceviewer.spec.ts: typography ramp, status cutout, button size, offsets, motion paintCoverage given up on purpose
useMediaCornerspath generation, which is visual only.StatusEditor.test.tsxstill covers selection and validation.Validation (head
cb32e0b65)Rebased onto
mainafter #1218 and #1262. #1218 reworked three of the MessageRow tests this PR deleted: own-row alignment, attachment placement, and thread-root styling. This PR keeps #1218's new versions and leaves them for the phase 3 merges. It also keeps the new delivery-polishsettlebefore scrolling.bin/pnpm typecheckandbin/pnpm design:typecheckare clean.InboxPage.test.tsx, which passed in isolation.profile-contrast.specand the mergedmessage-delivery-polish.specpassed on Chromium and WebKit (6 tests).tests/fixtures/design-system/viewer.spec.ts. Onmainit fails to load before any test runs, atsrc/shared/design-system/icons/claude.png: Unexpected character. It only runs fromjust scan, not from CI. That is pre-existing and left for a separate fix.🤖 Generated with Claude Code