Repository navigation
fix(deps): upgrade vulnerable tls and editor dependencies - #1267
Merged
Merged
Conversation
update rustls, prosemirror-view and source-map-js to patched versions. align the editor model and clipboard serializer with the required api. repair the goose fixture effort default to restore type checking. Signed-off-by: cyberpunk <d6839277d8e2b34d4f50da40d4de079dc36df4c282e87147aaaa2674c070cf5a@buzz.block.builderlab.xyz>
kalvinnchau
marked this pull request as ready for review
October 16, 2026 16:58
wpfleger96
approved these changes
Oct 16, 2026
wpfleger96
left a comment
Member
There was a problem hiding this comment.
🤖 thanks for this. checked the lockfiles: only rustls, prosemirror-model/view and source-map-js move, one resolved model version, and the rustls 0.23.46 checksum matches crates.io with the same dependency set as 0.23.44. the serializer change is the right adaptation: model 1.25.5+ serializes text nodes itself and no longer types a bare string as a valid top-level spec, so the text entry was dead and the unlinked-token span keeps the same clipboard text.
nonblocking: main already got the same effort: "" fixture fix in #1262, so that hunk drops out on merge and the paragraph about it in the description goes stale.
tellaho
added a commit
that referenced
this pull request
Oct 16, 2026
…ui-polish * buzz-app/main: test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 16, 2026
…lation * origin/main: (139 commits) feat(agents): let plugins read each agent's sessions (#1111) chore(deps): upgrade vitest to 5.0.4 (#1272) feat(plugins): reload folder plugins from the CLI (#1265) add channel shared sessions discovery and retrieval (#1254) polish Solo activity layout and fold previous steps (#1257) fix(agents): clarify model defaults and provider actions (#1177) fix(messages): stop the channel timeline jumping back when agents or search read old messages (#1256) Add Close other tabs to the tab menu (#1127) chore(deps): upgrade virtua to 0.53.5 and port its scroll patch (#1269) Auto-tag Berd drafts with a chosen default agent (#1139) test: delete styling, markup and call-count trivia tests (#1255) fix(hooks): preserve recovery ownership on lefthook 2.2.2 (#1174) fix(deps): upgrade vulnerable tls and editor dependencies (#1267) chore(terminal): upgrade xterm with compatible navigation (#1268) feat(goose): show goose and provider marks on agent cards (#1260) fix(agents): show native agent pictures in the Solo agent picker (#1258) test(agents): fix main typecheck — add effort to Goose fixture (#1262) fix(messages): reject unclaimed file and link drops app-wide (#1075) feat(channels): create and read system channels (#965) Refine message layout and bubble reading widths (#1218) ...
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the three priority dependencies with published security advisories:
rustls references: RUSTSEC-2026-0285, RUSTSEC-2026-0349. These records list GHSA aliases, not CVE aliases. The release also fixes 0346, 0347, and 0348; their required application configurations were not established in the audit.
ProseMirror view requires model ≥1.25.8. Update the direct model pin from 1.25.4 to 1.25.8 and keep a single resolved model version. Adapt clipboard serialization to the new model contract: let ProseMirror serialize text nodes and return a neutral span for unlinked tokens. A regression test verifies plain-text preservation, HTML escaping, and copy/paste round-tripping. It fails before the compatibility change and passes afterward.
The shared Goose test fixture also gains its missing empty
effortfield. This fixes two TypeScript errors reproduced on unchanged main and allows the required typecheck to run without bypassing hooks.Validation:
33ab0688, through the mandatory pre-push hook withBUZZ_TEST_WORKERS=2: 10,079 passed, 9 skipped, across 663 passing and 2 skipped files. The initial unrestricted run had 27 failures; the complete two-worker run passed without weakened assertions or retries.host_command::tests::aborting_the_read_kills_descendantsfailed twice withaborted command left a descendant running; later workspace suites did not run after that failure.pnpm testinvocation ended during Node integration without a final summary, so Node integration is recorded as incomplete.Human validation: Kalvin confirmed completing the requested native desktop smoke test on
cyberpunk/security-deps(head33ab0688) on October 16, 2026, with no issues reported. The checklist covered connection/reconnection, rich-text editing and undo/redo, copy/cut/paste, draft restoration and message editing, and native attachment/update checks where available. This records human-reported functional testing, not exploit reproduction or cross-platform certification. Windows and Linux manual validation remain unverified; the automated-test limitations above remain recorded.Collected broad-test evidence from the initial upgrade run (before the subsequent fixture correction): full Vitest reported 10,052 passed, 27 failed, 9 skipped across 646 passing, 17 failing, and 2 skipped files. No baseline reproduction of those failures is claimed. The original combined
pnpm testlog stops during Node integration without a final summary or recoverable exit code; the full chain is incomplete, not passed. Vitest test-list collection also produced no usable inventory. Subsequent validation should be reported separately against its actual code state.