镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(codex): set up Codex from the agent creation card, as Claude does - #1231

Merged
ngthuydiem merged 2 commits into
mainfrom
fizz/codex-create-install
Oct 15, 2026
Merged

ngthuydiem merged 2 commits into
mainfrom
fizz/codex-create-install

Conversation

@ngthuydiem

@ngthuydiem ngthuydiem commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

When Buzz has no copy of Codex yet, the Create agent card says "Codex is not installed." and offers only Try again. That button checks again but can't install anything. The only way out is knowing to open Settings → Agents → AI defaults → Codex.

This PR sends the not-installed case to the card's existing sign-in button. That button now runs the install step, the same way Codex's provider settings already do:

  • CodexSignIn takes a step (install or login) and shows Install Codex or Sign in. As before, it has a spinner and Cancel while the step runs, and shows the output below.
  • CreateModel shows that card for NOT_INSTALLED as well as SIGN_IN_ERROR, and also while CodexSetup's status is missing or signed-out. When the install finishes, the provider clears its error and checks again. The setup status doesn't change during that check, so the same button stays on screen and keeps keyboard focus as Install Codex becomes Sign in. Without this, the button was replaced by a new one and focus dropped to the page.

There is no dialog. Claude uses one because of its "Enter a code" step, and Codex sign-in has no code to type.

Screenshots (from a browser test page in Chromium, light theme; not the native app; the avatar is random)

Before (7a00171d) After (dd41607c) After, installing
Card shows Codex is not installed with only Try again Card shows Install Codex Install button spinning with Cancel

Validation (at b6781387)

  • tabs.test.tsx:
    • The card offers Install Codex and no Try again. A failed download keeps the offer and shows its output.
    • A successful install turns the same, still-focused button into Sign in, and signing in shows the models. Only the download is stubbed; setup.test.ts covers the download itself. This test fails without the tabs.tsx change.
  • vitest run src/bundled/codex src/bundled/agents src/features/agents: 669/669 pass. pnpm typecheck passes. Pre-commit and pre-push hooks pass.
  • Browser test page (Chromium, not committed), 1200 px and 420 px, light and dark: the layout holds. Keyboard: Enter on Install Codex keeps focus on it, Tab reaches Cancel, and focus stays on the button when it becomes Sign in.

Not done yet

  • Nobody has run this in the native app with a real download. To try it: on a profile with no ~/Library/Application Support/Buzz/codex, go to Agents → New agent → Codex and click Install Codex. The button should spin while Codex installs, then show Sign in. After you sign in, the model picker should appear.
  • Known, also true on main: if focus is on Cancel when a step ends by itself, Cancel disappears and focus drops to the page.

When Buzz had no copy of Codex, the creation card showed the error with
only Try again, which re-checks and cannot install. Route the missing
case to the same card action as sign-in, which now runs the install
step, as Claude's card and Codex's provider settings already do.

Co-authored-by: Diem Nguyen <diem@squareup.com>
Signed-off-by: Fizz <6be7be23ec5bba868f3e1db5ec86013d76bd1a293dce5b435a192158fec13641@buzz.block.builderlab.xyz>
@ngthuydiem ngthuydiem changed the title fix(codex): offer Install Codex on the agent creation card fix(codex): set up Codex from the agent creation card, as Claude does Oct 15, 2026
@ngthuydiem
ngthuydiem force-pushed the fizz/codex-create-install branch from 6501db9 to dd41607 Compare October 15, 2026 22:57
While the provider checks again after an install, its error is cleared,
so the card briefly became the model choices and Install Codex was
remounted as a new Sign in button, losing keyboard focus. Also key the
card off the setup status, which holds through that check.

Co-authored-by: Diem Nguyen <diem@squareup.com>
Signed-off-by: Fizz <6be7be23ec5bba868f3e1db5ec86013d76bd1a293dce5b435a192158fec13641@buzz.block.builderlab.xyz>
@ngthuydiem
ngthuydiem marked this pull request as ready for review October 15, 2026 23:24
@ngthuydiem
ngthuydiem requested a review from a team as a code owner October 15, 2026 23:24
@ngthuydiem
ngthuydiem merged commit 6687db1 into main Oct 15, 2026
32 checks passed
@ngthuydiem
ngthuydiem deleted the fizz/codex-create-install branch October 15, 2026 23:43
tellaho added a commit that referenced this pull request Oct 16, 2026
…ui-polish

* buzz-app/main: (43 commits)
  Unify file attachment cards and file-type artwork (#1220)
  feat(agents): start agents from relay-synced config copies (#1185)
  render shared sessions as attachment cards (#1217)
  fix(channels): keep other channels' permission reads alive across a delete (#1245)
  feat(channels): mark temporary channels in the sidebar (#1249)
  test(browser): fix six intermittent browser test failures and a composer caret bug (#1239)
  Close channel tabs together and make tab shortcuts predictable (#1154)
  Make message retry controls compact and accessible (#1221)
  fix(messages): end deferred composer focus on any focus move; stabilise hover-preview probe (#1244)
  fix(messages): keep restored-channel focus off the composer (#1243)
  fix(me): record reads in Solo chats opened from the sidebar (#1183)
  feat(inbox): archive or restore the open conversation with Control-Command-A (#1181)
  fix: keep panel divider dragging responsive (#1067)
  feat(agents): find people for agents through the relay's name-only profile search (#1124)
  fix(agents): explain why Create agent is disabled (#1232)
  feat(agents): run up to 8 Interests at once for every agent type (#1100)
  fix(codex): set up Codex from the agent creation card, as Claude does (#1231)
  Shrink the thread loading mark by a third (#1214)
  feat(agents): plugins add tools to every agent session (#1216)
  fix(sidebar): re-measure every drop target when a section resizes mid-drag (#1230)
  ...

Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants