镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: update all tooling - #2401

Closed
rubiin wants to merge 4 commits into
validatorjs:masterfrom
rubiin:tooling
Closed

rubiin wants to merge 4 commits into
validatorjs:masterfrom
rubiin:tooling

Conversation

@rubiin

@rubiin rubiin commented May 10, 2024 •

Copy link
Copy Markdown
Member

Updates all tools (expect mocha and nyc)
Also has the files linted (was not linted before thus many file changes )

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin
rubiin requested review from WikiRik and profnandaa May 10, 2024 15:34
@rubiin

rubiin commented May 10, 2024

Copy link
Copy Markdown
Member Author

I think this fixes things @profnandaa . We can do a beta release for this

Comment thread src/lib/alpha.js Resolved
Comment thread .github/workflows/ci.yml Resolved

@WikiRik WikiRik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change since we drop support for Node <18. So we'll need to keep that in mind when merging

@WikiRik WikiRik mentioned this pull request Jun 5, 2024
1 of 4 tasks
@pano9000

Copy link
Copy Markdown
Contributor

just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that?
I assume it has to do with linting?
But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

@rubiin

rubiin commented Aug 25, 2024

Copy link
Copy Markdown
Member Author

just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that? I assume it has to do with linting? But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

I could reroll the style changes but those are from eslint fix.

@WikiRik

WikiRik commented Aug 25, 2024

Copy link
Copy Markdown
Member

But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

Not 100% sure, but default configuration can change over minor versions and it might be due to a case that wasn't discovered in earlier versions but is now. If we want to not have those changes we can update the configuration manually

@rubiin rubiin mentioned this pull request Oct 8, 2024
@WikiRik WikiRik mentioned this pull request Nov 9, 2025
1 of 4 tasks
@rubiin

rubiin commented Nov 30, 2025

Copy link
Copy Markdown
Member Author

Gonna close this

@rubiin rubiin closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants