[WikiRik]

Updates the rollup version we use and introduces a separate build step in the CI so we test on the files that will also be published to npm. This also allows us to more easily update eslint in a future PR. It's a feat because there might be (very) minor changes to the build itself.

This incorporates part of the changes of #2401

Checklist

• PR contains only changes related; no stray files, etc.
• README updated (where applicable)
• Tests written (where applicable)
• References provided in PR (where applicable)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e36b279) to head (9a08c07).

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #2629   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2586      2586           
  Branches       656       656           
=========================================
  Hits          2586      2586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[WikiRik]

Because I want to validate that the regression of #2630 does not happen here, I will put this in draft

[WikiRik]

I specified the target for compilation in a661988 (#2629) and manually validated that it does not introduce the same regression as #2630

[rubiin]

LGTM then

[WikiRik]

@profnandaa if possible I want to include this in the next release as well, together with #2633

[tux-tn]

Thanks for the work on refreshing the old dependencies and tooling. It's really great to see progress in this area! Even though I haven’t contributed in the last few years, I’d be more than happy to help out where I can. I had tried to work on something back in #1869, but life happened and I never managed to finish it.

I also have a few suggestions and topics I’d like to raise. Do you think I should open a dedicated discussion issue for tooling, or is there already an ongoing conversation somewhere that I could join?

Regarding this PR specifically:

• Import attributes and in particular with { type: "json" } , aren’t supported in Node.js versions < 20.10.0. Since the Babel transpilation hook was removed from the build:browser command, this may break support for older Node.js versions.

• Node.js 24 is now the current LTS, so we probably want to add it to the CI test matrix.

Happy to discuss further and help where needed!

[WikiRik]

Thanks for your message!

I also have a few suggestions and topics I’d like to raise. Do you think I should open a dedicated discussion issue for tooling, or is there already an ongoing conversation somewhere that I could join?

There might be one, but that's probably quite old already so it would be good to open a new dedicated one.

• Import attributes and in particular with { type: "json" } , aren’t supported in Node.js versions < 20.10.0. Since the Babel transpilation hook was removed from the build:browser command, this may break support for older Node.js versions.

I will double check, but I thought that wasn't the case because Babel is still used in the build-browser script, just as a require argument.

• Node.js 24 is now the current LTS, so we probably want to add it to the CI test matrix.

Agreed. I didn't want to add it here before but there's no reason not to. Will update it with Node 24

[WikiRik]

I've fixed the merge issue which caused the CI to fail.

To get back to the earlier comment; the build step requires Node 20.10+, but it still transforms the code to work with older versions (as can be seen in the CI). That's why we split these steps.

[tux-tn]

LGTM. I suggest documenting that Node.js 20.10 or newer is required to build the project locally. This is not a real concern since Node.js versions below 20.10 are already EOL, and users should generally be running Node.js 22 or newer.

[tux-tn]

Do we still need to use the --legacy-peer-deps flag?

[WikiRik]

Yes, this step still runs on Node 8 etc