镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

build: move from npm to pnpm - #2400

Closed
rubiin wants to merge 4 commits into
validatorjs:masterfrom
rubiin:pnpm
Closed

rubiin wants to merge 4 commits into
validatorjs:masterfrom
rubiin:pnpm

Conversation

@rubiin

@rubiin rubiin commented May 10, 2024 •

Copy link
Copy Markdown
Member

This pr changes the package manager used from npm to pnpm along with on CI
also closes #2123

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@WikiRik

WikiRik commented May 10, 2024

Copy link
Copy Markdown
Member

How would this close the associated issue? The peer dependency versions are still conflicting until we update rollup

@rubiin

rubiin commented May 10, 2024 •

Copy link
Copy Markdown
Member Author

About that , pnpm doesnt have that peer dep issue when you run pnpm install. I am hoping to update the deps too but the browser stuff is failing

@WikiRik

WikiRik commented Jun 5, 2024

Copy link
Copy Markdown
Member

Let's revisit this after we've merged #2401

@rubiin rubiin closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency Issue: Installation via npm fails

2 participants