[tianrking]

Related issue: Resolves #45100

What changed

Remove a stale vulnerability_host_counts_old table immediately before the atomic rename. If an earlier run was interrupted after the rename but before cleanup, the next vulnerability processing run can now recover instead of failing on the existing backup table.

The regression coverage verifies both the SQL ordering and the recovery path against MySQL with a pre-existing stale table.

Checklist for submitter

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.

• Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

• Timeouts are implemented and retries are limited to avoid infinite loops

Testing

• Added/updated automated tests

• QA'd all new/changed functionality manually

Manual QA was not run because a local MySQL test service was unavailable. The SQL sequencing regression passed locally, and a MySQL integration regression is included for CI.

Summary by CodeRabbit

• Bug Fixes
  • Improved recovery of vulnerability host-count updates after interrupted table swaps.
  • Automatically removes stale temporary tables before retrying the update, helping ensure accurate vulnerability counts.
  • Added safeguards so cleanup failures are reported clearly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9fa1331a-586c-431c-a4e5-ebfd7d888615

📥 Commits

Reviewing files that changed from the base of the PR and between c200bed and f7e3888.

📒 Files selected for processing (3)

• changes/45100-vulnerability-host-count-swap-recovery
• server/datastore/mysql/vulnerabilities.go
• server/datastore/mysql/vulnerabilities_test.go

---

Walkthrough

The vulnerability host-count table swap now removes a stale vulnerability_host_counts_old table before the atomic rename. Cleanup errors are wrapped. SQL-mocked tests cover cleanup, schema creation, renames, transaction commits, and expectation validation. An integration test verifies recovery from a stale old table, resulting global counts, and old-table removal. A changelog entry documents the recovery behavior.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes recovery of vulnerability counts after interrupted table swaps.
Description check	✅ Passed	The description identifies the issue, explains the fix, documents testing, and notes the unavailable manual QA.
Linked Issues check	✅ Passed	The changes clean up stale swap state before renaming and add regression coverage, meeting issue #45100 objectives.
Out of Scope Changes check	✅ Passed	The changelog, implementation, and regression tests are directly related to the linked issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.53%. Comparing base (79305ea) to head (f7e3888).
⚠️ Report is 388 commits behind head on main.

Files with missing lines	Patch %	Lines
server/datastore/mysql/vulnerabilities.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #50898      +/-   ##
==========================================
- Coverage   68.53%   68.53%   -0.01%     
==========================================
  Files        3978     3978              
  Lines      256274   256277       +3     
  Branches    13627    13627              
==========================================
+ Hits       175632   175634       +2     
- Misses      65006    65008       +2     
+ Partials    15636    15635       -1     

Flag	Coverage Δ
backend	69.63% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[juan-fdz-hawa]

Thanks for the contrib!