Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds Nexus Shell version 1.6.9 as a maintained macOS application. The change defines Homebrew cask metadata, Darwin installation and uninstallation behavior, catalog registration, cleanup paths, and frontend icon mapping. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50822 +/- ##
=======================================
Coverage 68.53% 68.53%
=======================================
Files 3977 3978 +1
Lines 256142 256170 +28
Branches 13818 13818
=======================================
+ Hits 175535 175567 +32
+ Misses 64985 64983 -2
+ Partials 15622 15620 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI note: the failing No Nexus Shell metadata error is shown by this failed job. I am happy to adjust anything on the PR if maintainers prefer a different approach. |
|
@viewer12 thanks for submitting. I am curious, do you have any plans to get this into homebrew natively without a custom tap? We've submitted these on behalf of developers before if you need help. The only reason I ask is the "custom-tap" that we have created is for apps that can not be in homebrew that our customers have asked for. It doesn't function as a custom tap (like Let me know your thoughts or if you have any questions. |
|
Thanks — yes, I would appreciate help getting Nexus Shell into I had held back because the canonical repository is a small, binary-only releases repository and its raw GitHub notability metrics are low. I have since rechecked the current Acceptable Casks guidance, which notes that those metrics may not represent an application whose repository is used only to host binaries. I understand that this permits review rather than guaranteeing acceptance. The app otherwise follows the cask requirements:
If you prefer, I can open and maintain the native cask PR myself. If submitting it on behalf of the developer is easier for Fleet's workflow, I am happy to provide any metadata or verification you need. For this Fleet PR, waiting for the native cask seems preferable to adding an entry that must be updated manually. Once the cask is accepted, I can update this branch to consume it. |
|
@AdamBaali could you assist @viewer12 with getting his app, Nexus Shell, into homebrew so we can rely on that feed instead of our custom tap workflow? |
|
@allenhouchins @viewer12 there is already a cask PR for this: Homebrew/homebrew-cask#280752. @viewer12 opened and closed it on 13 August over the self-submission notability threshold and a livecheck source that needed work. That threshold is 225 stars, 90 forks or 90 watchers for a self-submission. The releases repo has 2 stars, so acceptance is unlikely. That said, maintainers can allow further review case by case, and a clean resubmission costs little, so it is worth another try. Happy to help get it in shape, we just should not plan the catalog entry around it landing. I validated 1.7.0 on macOS 15.7.7. The GitHub asset matches the vendor manifest SHA-256, the app is Developer ID signed and notarized, and install, uninstall and reinstall are clean. Keep the GitHub asset URL here, the vendor download 403s Homebrew CI. @viewer12 two fixes before you reopen:
One judgement call in that list: Reopen #280752 rather than opening a new one, and fill the template completely, the bot closed it last time for that. Our uninstall script needs these same paths regardless of what Homebrew does. |
- Adds related issue (if any), and if any of the manual QA checkboxes were selected. - Adds a -v verbose mode that also outputs who is assigned to the PR, a full link, and tags from the related issue Examples: ``` jonathan@jonathans-macbook-pro:~/repos/fleet-2$ ./tools/oncall/oncall.sh prs 51893 2026-08-25T17:29:40Z tested prateek-0490 Batch scheduled query name lookups when processing result logs 51881 2026-08-25T16:25:40Z nonpunctual Include script for printer configuration from CSV 51845 2026-08-25T04:20:44Z 49502 tested rajendrachavan Write a query and its labels in a single transaction 51731 2026-08-21T19:49:52Z tested prateek-0490 Validate software list order keys against an allowlist 51583 2026-08-19T19:34:15Z tested prateek-0490 Require a team selection when validating report run targets 51338 2026-08-17T05:23:53Z 50846 Dhvanit41 Hide the toast details panel when the payload is empty 51265 2026-08-14T17:54:28Z tested prateek-0490 Expand host script variables via the environment 51241 2026-08-14T14:32:34Z 50336 tested andymFleet 50336 apple business stale fleet names 51178 2026-08-13T20:18:48Z moojomoore Add macOS unlock user account action 51119 2026-08-13T05:28:14Z 50882 Dhvanit41 Return an error when refetching an Android host 51020 2026-08-12T00:46:05Z 40092 sjawhar Support credentialProviderPolicy in Android app configuration 50943 2026-08-11T12:31:48Z 46773 tested surajtripathy07 Add software custom targets warning to delete label modal 50898 2026-08-10T19:26:08Z 45100 tianrking Recover vulnerability counts after interrupted table swaps 50836 2026-08-08T19:23:13Z 50300 tested kitarp29 Adding the logic to make controls even when it's empty 50822 2026-08-08T01:35:19Z tested viewer12 Add Nexus Shell as a macOS Fleet-maintained app 50774 2026-08-07T15:14:11Z 50357 tested Dhvanit41 Clear stale failure detail when an Android profile becomes verified 49816 2026-07-23T13:19:19Z tested sleepy-slothh Fix Ubuntu OSV binary package matching 43774 2026-04-20T15:46:23Z BCTBB Helm - Gateway API support ``` ``` jonathan@jonathans-macbook-pro:~/repos/fleet-2$ ./tools/oncall/oncall.sh prs -v 51893 2026-08-25T17:29:40Z tested prateek-0490 #51893 Batch scheduled query name lookups when processing result logs 51881 2026-08-25T16:25:40Z nonpunctual #51881 Include script for printer configuration from CSV 51845 2026-08-25T04:20:44Z 49502 tested rajendrachavan lucasmrod #51845 Write a query and its labels in a single transaction bug, ~backend, ~released bug, #g-orchestration 51731 2026-08-21T19:49:52Z tested prateek-0490 juan-fdz-hawa #51731 Validate software list order keys against an allowlist 51583 2026-08-19T19:34:15Z tested prateek-0490 juan-fdz-hawa #51583 Require a team selection when validating report run targets 51338 2026-08-17T05:23:53Z 50846 Dhvanit41 #51338 Hide the toast details panel when the payload is empty bug, ~frontend, ~released bug, #g-auto-patching 51265 2026-08-14T17:54:28Z tested prateek-0490 georgekarrv #51265 Expand host script variables via the environment 51241 2026-08-14T14:32:34Z 50336 tested andymFleet JordanMontgomery #51241 50336 apple business stale fleet names bug, ~released bug, #g-apple-at-work 51178 2026-08-13T20:18:48Z moojomoore #51178 Add macOS unlock user account action 51119 2026-08-13T05:28:14Z 50882 Dhvanit41 #51119 Return an error when refetching an Android host bug, ~released bug, #g-byod 51020 2026-08-12T00:46:05Z 40092 sjawhar #51020 Support credentialProviderPolicy in Android app configuration ~feature fest, customer-pingali, #g-byod 50943 2026-08-11T12:31:48Z 46773 tested surajtripathy07 lucasmrod #50943 Add software custom targets warning to delete label modal bug, ~released bug, #g-orchestration, customer-susanoo 50898 2026-08-10T19:26:08Z 45100 tianrking juan-fdz-hawa #50898 Recover vulnerability counts after interrupted table swaps bug, ~released bug, ~community, #g-supply-chain, ~aging bug 50836 2026-08-08T19:23:13Z 50300 tested kitarp29 lucasmrod #50836 Adding the logic to make controls even when it's empty bug, ~gitops, #g-orchestration 50822 2026-08-08T01:35:19Z tested viewer12 AdamBaali #50822 Add Nexus Shell as a macOS Fleet-maintained app 50774 2026-08-07T15:14:11Z 50357 tested Dhvanit41 #50774 Clear stale failure detail when an Android profile becomes verified bug, ~released bug, #g-byod 49816 2026-07-23T13:19:19Z tested sleepy-slothh #49816 Fix Ubuntu OSV binary package matching 43774 2026-04-20T15:46:23Z BCTBB #43774 Helm - Gateway API support ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added an optional verbose mode for pull request listings, showing assignees, URLs, linked issue labels, and manual QA status. * Improved output formatting with aligned columns. * **Bug Fixes** * Unknown command-line arguments are now rejected with clearer usage guidance. * Improved detection of linked issues in pull request descriptions. * **Documentation** * Updated command usage information to describe the verbose option. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
@viewer12 closing this for now due to your last comment in the homebrew repo: Homebrew/homebrew-cask#280752 (comment) Feel free to notify me as soon as you get that added to homebrew. Looking forward to getting this added to Fleet's FMA catalog. |
Summary
Developer disclosure: I maintain Nexus Shell and am submitting this catalog entry transparently.
Verified metadata
1.6.9sameral.Nexus-Shell5MBFAB57U2088938eb901760a3123be7c8df18a41d480f234358a3a56f248de88bcc83a61dTesting
check-jsonschema.git diff --checkpassed.Other checklist sections in the general Fleet PR template do not apply to this maintained-app catalog contribution.
Summary by CodeRabbit