镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

chore(package): update deps - #3358

Merged
sidvishnoi merged 7 commits into
developfrom
deps_march
Mar 3, 2021
Merged

sidvishnoi merged 7 commits into
developfrom
deps_march

Conversation

@marcoscaceres

Copy link
Copy Markdown
Contributor

Closes #3355
Closes #3354
Closes #3353
Closes #3352
Closes #3351
Closes #3350

@marcoscaceres
marcoscaceres requested a review from sidvishnoi March 3, 2021 05:58
Comment thread package.json
"idb": "^6.0.0",
"jasmine": "^3.6.4",
"jquery": "^3.5.1",
"jquery": "^3.6.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we still have this here?

Comment thread tests/spec/core/data-include-spec.js Outdated
Comment on lines +144 to +150
const li = doc.querySelector("section li");
const li = doc.querySelector("section#test li");
expect(li).toBeTruthy();
expect(li.textContent).toContain("Rose");
expect(li.textContent).toContain("Blue");
expect(li.textContent).toContain("Red");
expect(li.textContent).toContain("wasteland");
expect(li.textContent).toBe("Rose");
const [p1, p2, p3] = [...doc.querySelectorAll("#test p")];
expect(p1.textContent).toContain("Blue");
expect(p2.textContent).toContain("Red");
expect(p3.textContent).toContain("wasteland");

@sidvishnoi sidvishnoi Mar 3, 2021 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See markedjs/marked#1934 (and the fix: markedjs/marked#1936)
cc: @saschanaz (don't know if this test was intentional as such)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention here was to wrap them to li. It seems marked now requires at least 3-space indentation here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3-space fixes it. Shouldn't be a breaking change for us as we've delegated markdown related changes on marked, which is commonmark compliant (almost).
Thanks!

@sidvishnoi
sidvishnoi merged commit a6574b1 into develop Mar 3, 2021
@sidvishnoi
sidvishnoi deleted the deps_march branch March 3, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants