镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: fix items between lists - #1936

Merged
UziTech merged 7 commits into
markedjs:masterfrom
UziTech:list-end
Feb 27, 2021
Merged

UziTech merged 7 commits into
markedjs:masterfrom
UziTech:list-end

Conversation

@UziTech

@UziTech UziTech commented Feb 10, 2021 •

Copy link
Copy Markdown
Member

Marked version: 2.0.0

Markdown flavor: Markdown.pl, CommonMark, GitHub Flavored Markdown

Description

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel

vercel Bot commented Feb 10, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/6F33HfppZUivANHrhsUD9SbwzyDk
✅ Preview: https://markedjs-git-fork-uzitech-list-end-markedjs.vercel.app

@UziTech UziTech changed the title fix list end fix: fix items between lists Feb 10, 2021
@jackw

jackw commented Feb 22, 2021

Copy link
Copy Markdown

Thanks so much for looking at this so quickly. I was wondering if there was any ETA on when this fix might make it into a release?

@UziTech

UziTech commented Feb 22, 2021

Copy link
Copy Markdown
Member Author

@jackw it should be just a few days until this is released. Once we have two approvals from team members we can merge it.

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@calculuschild calculuschild left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@calculuschild

Copy link
Copy Markdown
Contributor

I'm ok to merge this, but this has become another area with lots of checks for the pedantic option threaded throughout. Is there a point when it would be more legible (and maybe faster) having all the pedantic logic together behind a single check, even if there is a bit of code reuse?

@UziTech

UziTech commented Feb 27, 2021

Copy link
Copy Markdown
Member Author

Is there a point when it would be more legible (and maybe faster) having all the pedantic logic together behind a single check, even if there is a bit of code reuse?

Possibly not. I can't seem to find the conversation but I recall someone mentioning working on a whole different lexer and parser for pedantic and gfm. I don't know what ever happened to that.

I tend to prefer less code reuse so we don't have to remember to change the code in multiple places when updating it.

@UziTech
UziTech merged commit 46cdfc1 into markedjs:master Feb 27, 2021
@UziTech
UziTech deleted the list-end branch February 27, 2021 05:51
github-actions Bot pushed a commit that referenced this pull request Feb 27, 2021
## [2.0.1](v2.0.0...v2.0.1) (2021-02-27)

### Bug Fixes

* fix items between lists ([#1936](#1936)) ([46cdfc1](46cdfc1))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — 47e066b9 Deployed Feb 22, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lexer: Space after list appears in last list_item Whitespace after a list wraps all elements

4 participants