Repository navigation
Add loop messages feature - #18
rafaelalmeidatk wants to merge 6 commits into
Conversation
| @@ -0,0 +1,12 @@ | |||
| module.exports = [ | |||
There was a problem hiding this comment.
I am using a JS file instead of JSON because of the comments that are useful with channelId and the template strings for the multi-line messages
bpas247
left a comment
There was a problem hiding this comment.
Looks awesome so far 😃 just left a few comments to discuss the implementation details a bit further, otherwise 
| sendLoopMessages(); | ||
| }, INTERVAL_TIME); | ||
|
|
||
| sendLoopMessages(); |
There was a problem hiding this comment.
Is this to initially run it on startup?
There was a problem hiding this comment.
Yep, if the bot restarts for some reason then it already executes the function to update the channels
|
|
||
| async function sendLoopMessage(client, loopMessage) { | ||
| const channel = client.channels.get(loopMessage.channelId); | ||
| const channelMessages = await channel.fetchMessages({ limit: 50 }); |
There was a problem hiding this comment.
I'm guessing if the loop message is past 50 messages, it probably doesn't matter if we delete it or not 😛 I'm not exactly sure how the reactiflux website is parsing the job posts, not sure if it would pick up the bots messages for the jobs channel specifically.
There was a problem hiding this comment.
I'm guessing if the loop message is past 50 messages, it probably doesn't matter if we delete it or not
Yeah exactly.
I'm not exactly sure how the reactiflux website is parsing the job posts, not sure if it would pick up the bots messages for the jobs channel specifically.
I was gonna say that the bot only parses the messages that contain the tags ([FOR HIRE], [HIRING], etc) but I just realized that they are in the message content lol
Great catch, I will change the jobs script to ignore the messages from the bot
| const loopMessages = require("./messages.js"); | ||
|
|
||
| // time between each check to send a new loop message | ||
| const INTERVAL_TIME = 5 * 60 * 1000; // 5 minutes (ms) |
There was a problem hiding this comment.
Is 5 minutes an appropriate amount of time? Should it be longer? I'm not sure if we want this to be customization depending on the loop message.
There was a problem hiding this comment.
I am not sure, to be honest. The bot won't keep sending new messages if the last one is from it so a low interval time won't create spam, but the messages on #jobs aren't that active to hide the bot message if the interval time is too big. 🤔
There was a problem hiding this comment.
I'm not sure if we want this to be customization depending on the loop message.
The initial implementation had an interval field on each message, but I decided to remove it to avoid making it more complex than it is initially needed. We can add when we feel necessary.
There was a problem hiding this comment.
I increased the interval to 40 minutes
There was a problem hiding this comment.
ok now each message can have a different interval
|
I haven't reviewed this much yet, but my initial thoughts for the feature was just to have it be straight up a schedule of how often a message gets posted, and posting it. i was thinking node-cron for scheduling to keep it simple, not sure we need to check recent messages etc |
|
@vcarl I see, so it would be definitely more simple hm 🤔 |
| const jobs = { | ||
| tags: ["forhire", "for hire", "hiring", "remote", "local"], | ||
| handleMessage: ({ msg, user }) => { | ||
| if (msg.author.bot) return; |
There was a problem hiding this comment.
Is this strictly necessary?
There was a problem hiding this comment.
Yes? What benefit would we get if we had bots messaging/triggering each other?
There was a problem hiding this comment.
This is necessary because the bot may post a message in the #jobs channel that does not contain these tags so it would receive a warning from itself
|
May I ask why this wasn't merged? seems a waste |
With this feature, the bot will keep a message as the last one in a channel, with an interval between each post, to keep important information more visible to users.
I swear I couldn't find a better name for the module 😅 Suggestions are welcome
Closes #13