Repository navigation
test(stream): synchronize abort with the first delta - #196
Merged
Merged
Conversation
Replace the fixed abort timer with an observed text delta, verify iterator completion, and bound mock teardown even if abort propagation regresses. Cover both immediate and delayed responses.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Memory benchmarkCompared base
Interpretation: Differences larger than their measured MAD: Stable RSS +1.1 MiB ± 0.2 MiB, Physical peak +1.1 MiB ± 0.7 MiB. Extension overhead above pi baseline
Values are medians of 6 alternating, paired runs. The value after Environment: pi
|
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text_delta.abortedreason,Request abortedmessage and proof that the hanging upstream response is closed. Consume the iterator through actual completion, not just the first terminal-looking event.Why separately
The unchanged abort test failed twice during carry integration because its timer could fire before the first response data was received. This test-only PR isolates that race before the remaining redactor carry (#195).
Validation
PI_LOCAL_REQUIRED=1 OMP_COMPAT_REQUIRED=1 npm test: pass, including real Pi/OMP against mock APIs.npm run format:checkandgit diff --check: pass.commandcode/deepseek/deepseek-v4.1-flash; two initial nonblocking robustness notes addressed in the final candidate, focused re-review OK, no blockers.The normal project typecheck does not include all of
index.ts; the known 17 inherited expanded-probe diagnostics are not addressed here. No live paid calls or real login; no packed-artifact smoke claimed. No release/tag/publication.