Repository navigation
refactor(core): share credential redaction for diagnostics (carries #165) - #195
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Memory benchmarkCompared base
Interpretation: Differences larger than their measured MAD: Stable RSS -0.6 MiB ± 0.6 MiB. Extension overhead above pi baseline
Values are medians of 6 alternating, paired runs. The value after Environment: pi
|
This was referenced Nov 4, 2026
Carries #165 by patlux. Preserve URL query, fragment and userinfo stripping; add a preservation guard independent of the open diagnostics carry. Co-authored-by: Patrick Wozniak <email@patwoz.de>
pierreraby
force-pushed
the
carry/pr165-shared-redactor
branch
from
November 4, 2026 14:03
ffc4f9c to
e7cd59e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries #165's shared-redactor fix (
8a2dc73) by @patlux / Patrick Wozniak, credited as co-author. Runtime source changes match the original commit; recalibrated on main after the other eight carries and the separate deterministic-abort test (#196).redactCommandCodeErrorText.This is defensive hardening, not a confirmed production leak. It does not import or depend on open diagnostics PR #180. That carry adds content-free diagnostics, not raw error text storage; retain both additions when integrating runtime/test changes.
Validation
e7cd59e329df867f7ff19e6d713d052d60e503ebon main590ef638c119539bc72718998d501a6872b608cf: fullPI_LOCAL_REQUIRED=1 OMP_COMPAT_REQUIRED=1 npm testPASS, including the deterministic abort test and real Pi/OMP mock integration.unknownboundary parameter / large class).The original nine-carry independent review covered this unchanged source patch. The separate abort stabilization received a focused DeepSeek V4.1 Flash review and re-review (OK). No real secrets, live login, billed requests, packed-artifact smoke or release. #165 is currently closed non-merged; the maintainer has chosen to retain that status after integration and add the final carry summary there.