镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Remove Interactive EU from frontpage - #909

Merged
lpinca merged 3 commits into
nodejs:masterfrom
phillipj:remove-interactive-eu
Sep 23, 2016
Merged

lpinca merged 3 commits into
nodejs:masterfrom
phillipj:remove-interactive-eu

Conversation

@phillipj

Copy link
Copy Markdown
Member

Since the conference has ended, it's about time to remove the Interactive EU banner from the frontpage?

BEFORE

screen shot 2016-09-22 at 15 37 16

AFTER

screen shot 2016-09-22 at 15 38 00

@lpinca

lpinca commented Sep 22, 2016

Copy link
Copy Markdown
Member

I think the relevant CSS media queries should also be tweaked.

Now that there's only one event and the logo remaining, there's no
need for two logo's which is hidden/displayed responsively.
@phillipj

Copy link
Copy Markdown
Member Author

Thanks for the reminder @lpinca! Did a small CSS refactoring and simplified HTML a bit. Still looks the same as the after screenshot, just w/o the redundant code.

Comment thread layouts/index.hbs Outdated
alt="Node.js Interactive" />
</span>
<a class="interactive-item" href="http://events.linuxfoundation.org/events/node-interactive">
<img src="/static/images/interactive/nodejs-interactive-logo-center.png" />

@lpinca lpinca Sep 22, 2016 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wrapper span is still required or the image will not be scaled well. This is how it looks in Chrome, responsive mode (Tablet - 768px):

capture

@lpinca

lpinca commented Sep 22, 2016

Copy link
Copy Markdown
Member

Do we care about IE11? If so can anyone test this on IE11? I remember I spent some time to make this banner work there.

@phillipj

Copy link
Copy Markdown
Member Author

If so can anyone test this on IE11? I remember I spent some time to make this banner work there.

Scaling of logo and responsiveness looks to be working as expected on my win7/IE11 VM.

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca
lpinca merged commit 8a32f54 into nodejs:master Sep 23, 2016
@williamkapke

Copy link
Copy Markdown
Contributor

Now that this is merged, I realized that the background is Amsterdam and it should probably be Austin. heh

I'll reach out to them and see if they can provide a new image for Austin.

@lpinca

lpinca commented Sep 23, 2016 •

Copy link
Copy Markdown
Member

@williamkapke we can cut the background. The right part should be correct, it is huge.

background

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants