镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Update Interactive US banner with Dec 2nd date - #898

Merged
lpinca merged 1 commit into
masterfrom
interactive_logo
Sep 23, 2016
Merged

lpinca merged 1 commit into
masterfrom
interactive_logo

Conversation

@williamkapke

Copy link
Copy Markdown
Contributor

Fixes #870

@williamkapke

Copy link
Copy Markdown
Contributor Author

Hm, looks like the current one has some transparency and the new one doesn't. I'll see if I can modify it.

@williamkapke

Copy link
Copy Markdown
Contributor Author

I couldn't modify it myself. Cassandra has asked for an updated one- which she'll relay to me.

@williamkapke

Copy link
Copy Markdown
Contributor Author

Ok- pushed the latest they sent me. It seems a bit different...? The color is off :/

With @phillipj 's #909 this might not make a difference. Some please tell me if I need to go back and ask for another version or merge it!

@phillipj phillipj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as you said the slight brightness difference will not be an issue with the EU banner removed

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #909 is merged.

@lpinca
lpinca merged commit b067e72 into master Sep 23, 2016
@lpinca
lpinca deleted the interactive_logo branch September 23, 2016 07:12
@phillipj

Copy link
Copy Markdown
Member

Thanks for pinging the right people and fixing this @williamkapke 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants