Repository navigation
Exclude global types from devtools user test - #20172
Merged
Wesley Wigham (weswigham) merged 1 commit intoNov 20, 2017
Merged
Conversation
Wesley Wigham (weswigham)
requested a review
from Nathan Shively-Sanders (sandersn)
November 20, 2017 22:55
Nathan Shively-Sanders (sandersn)
approved these changes
Nov 20, 2017
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
A couple of questions, although I think it's fine to merge.
| node_modules/chrome-devtools-frontend/front_end/cm/comment.js(6,17): error TS2307: Cannot find module '../../lib/codemirror'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/comment.js(7,19): error TS2304: Cannot find name 'define'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/comment.js(7,43): error TS2304: Cannot find name 'define'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/comment.js(8,5): error TS2304: Cannot find name 'define'. | ||
| node_modules/chrome-devtools-frontend/front_end/cm/markselection.js(12,9): error TS2304: Cannot find name 'require'. |
There was a problem hiding this comment.
should it have 'node' in order to find require?
Member
Author
There was a problem hiding this comment.
require in these files is part of a UMD header. It's not actually in use, in the strictest sense:
(function(mod) {
if (typeof exports == "object" && typeof module == "object") // CommonJS
mod(require("../../lib/codemirror"));
else if (typeof define == "function" && define.amd) // AMD
define(["../../lib/codemirror"], mod);
else // Plain browser env
mod(CodeMirror);
})(function(CodeMirror) {and chrome doesn't define it in their externs file (likely because the entire cm folder is marked as external, and so is not strictly checked).
| @@ -5866,7 +5886,7 @@ node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(8795,39): error | |||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(8799,38): error TS2339: Property 'offset' does not exist on type '{ [x: string]: any; node: any; start: number; end: number; collapse: any; coverStart: any; coverE...'. | |||
| Property 'offset' does not exist on type '{ [x: string]: any; node: any; start: number; end: number; collapse: any; coverStart: any; coverE...'. | |||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(8817,16): error TS2345: Argument of type 'boolean' is not assignable to parameter of type 'number'. | |||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(8818,3): error TS2322: Type 'Timer' is not assignable to type 'boolean'. | |||
| node_modules/chrome-devtools-frontend/front_end/cm/codemirror.js(8818,3): error TS2322: Type 'number' is not assignable to type 'boolean'. | |||
There was a problem hiding this comment.
is this a result of this change, or just an update in the baselines?
Member
Author
There was a problem hiding this comment.
node re-typed setTimeout to return Timer instead of just number.
Member
|
This only gets rid of a few of the absolute paths in error messages. I agree that we should address this generally in the compiler. |
Member
Author
|
Mohamed Hegazy (@mhegazy) already opened #20178 to track |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it contained a handful of conflicting declarations which happened to trigger an error from #19356, which has a machine-specific path in the message.
Could we revert #19356 and instead implement #10489 in the near future? At least internally I don't think we've ever been happy with seeing those paths in any baselines; especially when they appear in a library file.