Repository navigation
Subsequent variable declarations must have same type: Mention location of other declaration - #19356
Merged
2 commits merged intoOct 20, 2017
Merged
2 commits merged into
2 commits merged into
Conversation
…n of other declaration
ghost
requested a review
from Nathan Shively-Sanders (sandersn)
October 19, 2017 22:09
Nathan Shively-Sanders (sandersn)
approved these changes
Oct 19, 2017
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
Just some minor naming/formatting changes.
| const valueDeclarationSourceFile = getSourceFileOfNode(firstDeclaration); | ||
| const otherSpan = getErrorSpanForNode(valueDeclarationSourceFile, getNameOfDeclaration(firstDeclaration) || firstDeclaration); | ||
| const otherLocation = getLineAndCharacterOfPosition(valueDeclarationSourceFile, otherSpan.start); | ||
| const otherLocationDescription = `${valueDeclarationSourceFile.fileName} ${otherLocation.line}:${otherLocation.character}`; |
There was a problem hiding this comment.
is the chrome debugger issue with template literals fixed? It doesn't look like it, so probably it's better not avoid template literals for now.
| } | ||
| } | ||
|
|
||
| function errorSubsequentVariableDeclarationMustHaveSameType(firstDeclaration: Declaration, firstType: Type, nextDeclaration: Declaration, subsequentType: Type): void { |
There was a problem hiding this comment.
I'd use 'Next' consistently for the function name and for -Type and -Declaration. It's easier to type than subsequent.
|
|
||
| function errorSubsequentVariableDeclarationMustHaveSameType(firstDeclaration: Declaration, firstType: Type, nextDeclaration: Declaration, subsequentType: Type): void { | ||
| const valueDeclarationSourceFile = getSourceFileOfNode(firstDeclaration); | ||
| const otherSpan = getErrorSpanForNode(valueDeclarationSourceFile, getNameOfDeclaration(firstDeclaration) || firstDeclaration); |
There was a problem hiding this comment.
and 'first/next' for local names too.
ghost
deleted the
subsequent
branch
October 20, 2017 15:33
This was referenced Nov 20, 2017
4 tasks done
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19339