[Mark Hildebrand (hildebrandmw)]

Consolidate input::Registered and input::internal::DynInput into just input::internal::Input. We can then use two constructors:

impl Input {
    // construct an `Input` for an actual input.
    fn new<T>() -> Self where T: Input;

    // construct a feature gated input.
    fn gated(tag: &'static str, features: Features) -> Self;
}

The trickiest update is Registry::register_input, which consolidates the two methods Registry::register_input<T: Input> and Registry::register_gated into a single method handling all registry conflicts. As a small bonus, this methods is no longer forced to be monomorphized for every input T, helping with compile times.

This technically breaks API with the removal of input::Registered<'_>, but our external and internal uses don't need this type.

[Copilot]

🟡 Changes recommended

It removes the public Registry::input API without accounting for that additional compatibility break.

1 open finding

• Changing Registry::input visibility breaks downstream callers · New

What changed in this PR

Simplifies benchmark input handling by consolidating dynamic input representations.

Changes:

• Introduces a unified internal Input wrapper.
• Consolidates input registration and conflict handling.
• Updates tolerance and formatting paths to use the new representation.

File	Description
app.rs	Uses unified inputs for display and formatting.
benchmark.rs	Returns owned tolerance inputs.
input.rs	Implements the unified internal input representation.
jobs.rs	Formats unified input references.
registry.rs	Consolidates registration and stores unified inputs.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Codecov Comments Bot (codecov-commenter)]

Codecov Report

❌ Patch coverage is 95.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.95%. Comparing base (177c03b) to head (b79e8bf).

Files with missing lines	Patch %	Lines
diskann-benchmark-runner/src/input.rs	89.39%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files         586      586           
  Lines      118173   118173           
=======================================
+ Hits       107483   107488    +5     
+ Misses      10690    10685    -5     

Flag	Coverage Δ
miri	90.95% <95.00%> (+<0.01%)	⬆️
unittests	90.65% <95.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
diskann-benchmark-runner/src/app.rs	86.80% <100.00%> (ø)
diskann-benchmark-runner/src/benchmark.rs	90.90% <100.00%> (ø)
diskann-benchmark-runner/src/jobs.rs	96.72% <100.00%> (ø)
diskann-benchmark-runner/src/registry.rs	93.62% <100.00%> (-0.13%)	⬇️
diskann-benchmark-runner/src/input.rs	92.36% <89.39%> (+4.12%)	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.