Repository navigation
Fix intermittent workspace deletion failure on AMPLS private DNS zone group - #4943
Marcus Robinson (marrobi) wants to merge 3 commits into
Conversation
|
/test-extended 6913bc8 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/28439115435 (with refid (in response to this comment from Marcus Robinson (@marrobi)) |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 168d2dc. ♻️ This comment has been updated with latest results. |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-tre6ce7a05c)... (run: https://github.com/microsoft/AzureTRE/actions/runs/28443377750) |
|
PR test environment destroy complete (RG: rg-tre6ce7a05c) |
|
/test-extended 6913bc8 |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/28444967600 (with refid (in response to this comment from Marcus Robinson (@marrobi)) |
|
/test-extended 168d2dc |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/28657797536 (with refid (in response to this comment from Marcus Robinson (@marrobi)) |
|
/test-extended 168d2dc |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/28659929876 (with refid (in response to this comment from Marcus Robinson (@marrobi)) |
|
/test-destroy-env |
|
Destroying PR test environment (RG: rg-tre6ce7a05c)... (run: https://github.com/microsoft/AzureTRE/actions/runs/28667004895) |
|
PR test environment destroy complete (RG: rg-tre6ce7a05c) |
|
Copilot update this branch from upstream main. |
|
For information: #5281 fixes #3193 in the same file with a different method. It does not retry. Terraform removes the two scope links, waits 5 minutes, and then deletes the DNS zone group and the private endpoint. In live tests in another fork, 6 of 6 workspace deletes with the wait passed. #5281 also makes the App Insights link depend on the private endpoint, because the reverse order causes the HTTP 403 in #5280. This pull request makes the endpoint depend on both links, so the two pull requests conflict. If #5281 merges, this pull request needs a rebase without that dependency. |
Resolves #3194. Adds an azapi delete retry (+ timeouts) to the Azure Monitor private DNS zone group so transient AnotherOperationInProgress 409s during destroy are retried instead of failing.