Repository navigation
Workspace azmonitor depends on airlock - #3194
Merged
Tamir Kamara (tamirkamara) merged 1 commit intoFeb 5, 2023
Merged
Conversation
Tamir Kamara (tamirkamara)
marked this pull request as ready for review
February 5, 2023 09:10
Anat Balzam (anatbal)
approved these changes
Feb 5, 2023
Collaborator
Author
|
/test-extended |
Tamir Kamara (tamirkamara)
enabled auto-merge (squash)
February 5, 2023 09:20
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4095907898 (with refid (in response to this comment from Tamir Kamara (@tamirkamara)) |
1 similar comment
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4095907898 (with refid (in response to this comment from Tamir Kamara (@tamirkamara)) |
Tamir Kamara (tamirkamara)
deleted the
tamirkamara/3193-workspace-delete
branch
February 5, 2023 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
Sometimes a conflict will occur when a workspace is being deleted. The source of this is networking changed done inside the airlock and az-monitor modules of the bundle.
This should be handled by terraform without manual intervention, but since it seem to not happen like that...
How is this addressed