镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix a bug in does not display of the table cell if it empty. - #697

Closed
icm7216 wants to merge 2 commits into
markedjs:masterfrom
icm7216:fix_display_table_cell
Closed

icm7216 wants to merge 2 commits into
markedjs:masterfrom
icm7216:fix_display_table_cell

Conversation

@icm7216

@icm7216 icm7216 commented Dec 18, 2015

Copy link
Copy Markdown

Fix this issue. In the table cell does not display if bottom right corner of the table cell is empty.
This fix #188, fix #476, fix #693, and fix atom/markdown-preview#206

before the fix

before_fix

after the fix

after_fix

@DoumanAsh

Copy link
Copy Markdown

Glad to see that someone already fixed :)
Sad that i didn't find it before i started to look into it...

It is btw shouldn't if the last empty cell has nothing inside(including no spaces)

@DanielSmedegaardBuus

Copy link
Copy Markdown

Why isn't this merged? It's been over 18 months :D

@DanielSmedegaardBuus

Copy link
Copy Markdown

Thanks, @icm7216 !

Since this doesn't seem to be merged anytime soon, I forked marked and merged it into my own fork.

@redfast00

Copy link
Copy Markdown

Can this or #357 be merged? :D

@joshbruce

Copy link
Copy Markdown
Member

#980

@joshbruce joshbruce removed this from the 0.4.0 - No known defects milestone Apr 4, 2018
@icm7216

icm7216 commented May 16, 2018

Copy link
Copy Markdown
Author

This issue seems to be solved by #1245. My PR is no longer needed. Thanks everyone.

marked_gfm_table

@icm7216 icm7216 closed this May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants