镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Table ending in empty cell - #357

Closed
drscannell wants to merge 2 commits into
markedjs:masterfrom
drscannell:table-ending-in-empty-cell
Closed

drscannell wants to merge 2 commits into
markedjs:masterfrom
drscannell:table-ending-in-empty-cell

Conversation

@drscannell

Copy link
Copy Markdown

Currently, if the last cell of a table is empty, it will be dropped from the HTML:

| Header 1 | Header 2 |
|----------|----------|
| Cell 1   | Cell 2   |
| Cell 3   |          |

This pull request does the following:

  1. Add test for situation described above
  2. Fix bug causing the the last cell to not be added during conversion to HTML.

@rhiokim

rhiokim commented Mar 4, 2014

Copy link
Copy Markdown

+1

@servant-42

Copy link
Copy Markdown

+1, also reported in #188

servant-42 added a commit to CSNW/marked that referenced this pull request May 13, 2014
@utensil

utensil commented May 25, 2014

Copy link
Copy Markdown

+1

@benelog

benelog commented Aug 24, 2016

Copy link
Copy Markdown

👍

@MaXFalstein

Copy link
Copy Markdown

Is there any reason why this pull request has not been merged?

@redfast00

Copy link
Copy Markdown

+1, there is another PR for the same bug in #697

@JoshuaKGoldberg

Copy link
Copy Markdown

Ping @chjj

@joshbruce

Copy link
Copy Markdown
Member

#980

@joshbruce joshbruce added this to the 0.4.0 - No known defects milestone Dec 25, 2017
@joshbruce joshbruce removed this from the 0.4.0 - No known defects milestone Apr 4, 2018
@styfle

styfle commented Jul 10, 2018

Copy link
Copy Markdown
Member

Thanks for the PR but this is already fixed.
See the demo to see it working in the latest version of marked.

@styfle styfle closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants