镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Fix: use named exports only for ESM build - #2226

Merged
styfle merged 1 commit into
markedjs:masterfrom
benmccann:esm-entry
Oct 7, 2021
Merged

styfle merged 1 commit into
markedjs:masterfrom
benmccann:esm-entry

Conversation

@benmccann

Copy link
Copy Markdown
Contributor

Marked version: 3.0.6

Markdown flavor: all

Description

Expectation

UMD build should have only default export for backwards compatibility. CJS cannot have both named and default exports like ESM can

Result

Backwards compatibility broke in UMD build

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel

vercel Bot commented Oct 6, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/7hqcLD8XkkvDd67KoNgefVcPbU9B
✅ Preview: https://markedjs-git-fork-benmccann-esm-entry-markedjs.vercel.app

@UziTech UziTech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@benmccann

Copy link
Copy Markdown
Contributor Author

No problem. Sorry I broke things

@UziTech

UziTech commented Oct 7, 2021

Copy link
Copy Markdown
Member

Happens to all of us ☺️

@ddolcimascolo

Copy link
Copy Markdown

Hi guys, do you plan to release a patched version soon?

Thx,
David

@styfle
styfle merged commit 223e61d into markedjs:master Oct 7, 2021
@RomanHotsiy

RomanHotsiy commented Oct 7, 2021 •

Copy link
Copy Markdown
Contributor

@UziTech @styfle could you please cut a new release 🙏. This breaks our customer builds.

@github-actions

github-actions Bot commented Oct 7, 2021

Copy link
Copy Markdown

🎉 This PR is included in version 3.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ddolcimascolo

Copy link
Copy Markdown

Thx

This branch was successfully deployed

1 active deployment
Preview — c6f21f26 Deployed Oct 6, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants