镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: revert #2223 - #2224

Closed
UziTech wants to merge 1 commit into
markedjs:masterfrom
UziTech:revert-2223
Closed

UziTech wants to merge 1 commit into
markedjs:masterfrom
UziTech:revert-2223

Conversation

@UziTech

@UziTech UziTech commented Oct 6, 2021

Copy link
Copy Markdown
Member

It seems like #2223 turned lib/marked.js into a ES Module which would be a breaking change.

This reverts #2223

@vercel

vercel Bot commented Oct 6, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/markedjs/markedjs/B4Zp9q7u2BaXz2Rz6akyuxRMH18K
✅ Preview: https://markedjs-git-fork-uzitech-revert-2223-markedjs.vercel.app

@Conduitry

Conduitry commented Oct 6, 2021 •

Copy link
Copy Markdown

@UziTech

UziTech commented Oct 6, 2021

Copy link
Copy Markdown
Member Author

Object.defineProperty(exports, '__esModule', { value: true });

it is

@benmccann benmccann mentioned this pull request Oct 6, 2021
1 of 5 tasks
@benmccann

Copy link
Copy Markdown
Contributor

I'm not sure what issue you're seeing? As far as I know, I don't think there's any breaking change here. But if you'd like to remove that line, I think a better solution would be this: #2225

@UziTech UziTech closed this Oct 6, 2021
@UziTech

UziTech commented Oct 6, 2021

Copy link
Copy Markdown
Member Author

The breaking change is that methods like setOptions are not available on marked when including marked.min.js in a script tag like <script src="https://unpkg.com/marked@3.0.5/marked.min.js" async=""></script>

@UziTech UziTech reopened this Oct 6, 2021
@UziTech

UziTech commented Oct 6, 2021

Copy link
Copy Markdown
Member Author

looks like #2225 didn't fix it it only removed the __esModule property

@benmccann

Copy link
Copy Markdown
Contributor

I'm looking at this right now to see if there's a better fix now that I know how to reproduce the issue

@benmccann

Copy link
Copy Markdown
Contributor

Here's a fix for the issue: #2226

@UziTech UziTech closed this Oct 7, 2021
@UziTech
UziTech deleted the revert-2223 branch November 21, 2022 06:49

This branch was successfully deployed

1 active deployment
Preview — 6e5758d7 Deployed Oct 6, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants