Repository navigation
Rugged::Repository.clone_at checkout_branch option - #339
Merged
arthurschreiber merged 3 commits intoMar 25, 2014
Merged
arthurschreiber merged 3 commits into
arthurschreiber merged 3 commits into
Conversation
libgit2 and assign it. add tests for checkout_branch
Member
There was a problem hiding this comment.
This is a good idea, but does not work. The credentials returned by ssh_key_credential don't work with the repo at libgit2/TestGitRepository.
Fixing this test case will involve a lot of changes to make use of the locally served repository, and it's not really in scope for this Pull Request. CAn you just remove this test for now so I can get your changes merged without breaking the build?
Member
|
Sorry for all these nitpicks. If you can incorporate these changes. this PR will be good to be merged. 😄 |
…ravis build. Added assertion to test_clone_with_branch
Contributor
Author
|
Yep. All set now I think. |
arthurschreiber
added a commit
that referenced
this pull request
Mar 25, 2014
…ranch Rugged::Repository.clone_at checkout_branch option
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up where #338 left off.