Repository navigation
Fix for #336 - #338
Closed
albertsun wants to merge 2 commits into
Closed
Fix for #336#338albertsun wants to merge 2 commits into
albertsun wants to merge 2 commits into
Conversation
…git2 and assign it
Merged
Member
There was a problem hiding this comment.
Can you just reuse val here, instead of introducing another variable?
Contributor
Author
|
Yes, that's better. Was having trouble debugging something and thought that re-using that variable might have been causing trouble but it was unrelated. Going to make a new branch and pull request to squash everything into one commit. |
Member
There was a problem hiding this comment.
I think it should be enough if you check that:
assert_equal "refs/heads/packed", repo.references["HEAD"].target_id
The other assertions you have in this test don't really have anything to do with the :checkout_branch option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the name of the option to
checkout_branchfrombranchto more closely match the libgit2 option here https://github.com/proxy/libgit2.github.com/libgit2/#HEAD/type/git_clone_options