Fix macOS FMA relaunch for bundle IDs with non-identifier characters by allenhouchins · Pull Request #53570 · fleetdm/fleet

allenhouchins · 2026-09-19T02:31:14Z

Related issue: NA — found while reviewing #53566

Checklist for submitter

Changes file added for user-visible changes in changes/.
Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.

What & why

quit_and_track_application and relaunch_application derive the name of the "was it running" flag from the bundle ID and interpolate it into an eval:

local var_name="APP_WAS_RUNNING_$(echo "$bundle_id" | tr '.-' '__')"
eval "export $var_name=1"

tr '.-' '__' maps only dots and dashes. Any other character survives into the variable name, and a space breaks the eval in two:

Write: eval "export APP_WAS_RUNNING_org_mozilla_pale moon=1" — export takes two arguments, so it sets APP_WAS_RUNNING_org_mozilla_pale and a stray moon=1. The intended variable is never set.
Read: eval "was_running=$APP_WAS_RUNNING_org_mozilla_pale moon" — assigns empty, then tries to run moon as a command, printing moon: command not found into the install output.
Result: was_running is empty, so relaunch_application returns early.

Pale Moon hits this today. pale-moon.json has "unique_identifier": "org.mozilla.pale moon", and the shipped script calls quit_and_track_application 'org.mozilla.pale moon'. The app is quit during an update and never reopened. It is the only one of the 967 shipping macOS FMAs affected — every other identifier is drawn from [A-Za-z0-9._-].

This replaces the derivation with bash parameter expansion that maps everything outside [A-Za-z0-9_]:

local var_name="APP_WAS_RUNNING_${bundle_id//[^[:alnum:]_]/_}"

Also applied to the thirteen custom install scripts under inputs/homebrew/scripts/ that carry their own copy of these functions, so the two don't drift.

Reviewer notes

Inert for every app but pale-moon. For identifiers drawn from [A-Za-z0-9._-] the new mapping produces a byte-identical variable name to tr '.-' '__'. I compared old vs. new across all 967 homebrew unique_identifier values: 966 identical, 1 changed (pale-moon, the broken one). Runtime behavior for every other app is unchanged.
Why parameter expansion instead of tr -c '[:alnum:]_' '_'. Same result, but no subshell, and it sidesteps two hazards: echo appends a newline that tr -c would map to a trailing underscore, and BSD vs. GNU tr differences in CI. Verified on /bin/bash 3.2, the macOS runtime — generated scripts have used a bash shebang since Use bash shebang in generated scripts #44836.
No output regeneration here. This changes a shared function body, so all 956 generated scripts containing it will shift by two lines when the nightly regenerates. That matches how prior changes to these same functions landed (Relaunch apps via open as console user #43842, Check osascript output instead of exit status #42951, Use bash shebang in generated scripts #44836 were all generator-only).
Not a security fix. unique_identifier comes from Fleet's own input files, not the brew API, so this isn't the untrusted-input class Escape cask metadata in Homebrew Fleet-maintained-app script generation #51324 addressed. Hardening the eval is still worthwhile because the name reaches a root-privileged eval, but the bug being fixed is the relaunch failure.

Testing

Added/updated automated tests

TestQuitRelaunchVarNameSurvivesEval runs the real write/read round trip through bash for four shipping identifier shapes including org.mozilla.pale moon, and asserts the flag survives. TestQuitRelaunchVarNameNeutralizesCommandSubstitution asserts the derived name is a bare shell identifier and that a $(touch ...) payload doesn't execute. TestQuitAndRelaunchDeriveVarNameIdentically pins the two derivations to the same line so they can't drift, and TestCustomInstallScriptsDoNotUseOldVarNameDerivation fails if any custom install script still uses tr '.-' '__'.

Confirmed these fail against the old derivation: under set -u, pale-moon errors with APP_WAS_RUNNING_org_mozilla_pale: unbound variable; without it, the read back is silently empty.
QA'd all new/changed functionality manually

go test ./ee/maintained-apps/... passes. bash -n clean on all thirteen patched custom scripts. go vet and gofmt clean. (make lint-go-incremental couldn't run locally — it needs a network clone of golangci-lint — so leaving that to CI.)

AI

AI: Claude Code (claude-opus-5)

Summary by CodeRabbit

Bug Fixes
- Fixed macOS app updates so Fleet-maintained apps with spaces or other special characters in their bundle identifiers can relaunch successfully.
- Improved tracking of whether applications were running before installation for identifiers containing special characters.
Tests
- Added coverage for application tracking with special-character identifiers.

quit_and_track_application and relaunch_application derive the name of the "was it running" flag from the bundle ID and pass it through eval, but only mapped dots and dashes. A bundle ID containing a space split the eval into two assignments, so the flag never landed under the name relaunch reads back and the app was quit during an update but never reopened. Pale Moon (org.mozilla.pale moon) hits this today. Map every character outside [A-Za-z0-9_] via bash parameter expansion, which also drops a subshell and the echo trailing-newline edge case. For bundle IDs drawn from [A-Za-z0-9._-] the derived name is unchanged, so this is inert for 966 of the 967 shipping macOS FMAs. Applied to the generator and to the nine custom install scripts carrying their own copy of the same functions.

Copilot

Warning

Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Copilot review overview

🟡 Changes recommended

Regenerate the affected checked-in output manifests so the production Pale Moon script includes the fix.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Regenerate shipped Pale Moon manifest after template fix · New

What changed in this PR

Fixes macOS FMA relaunch tracking for bundle IDs containing spaces or special characters.

Changes:

Sanitizes bundle IDs consistently in generated and custom scripts.
Adds Bash regression and safety tests.
Adds a user-visible changes record.
The checked-in Pale Moon output still needs regeneration to include the fix.

File	Description
`ee/maintained-apps/inputs/homebrew/scripts/webex_install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/teleport-suite-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/pd-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/openvpn-connect-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/harmony-sase-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/github-desktop-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/docker_desktop_install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/cycling74-max-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/inputs/homebrew/scripts/claude-install.sh`	Updates relaunch variable derivation.
`ee/maintained-apps/ingesters/homebrew/scripts.go`	Updates the generated script template.
`ee/maintained-apps/ingesters/homebrew/scripts_test.go`	Adds regression coverage.

Files excluded by content exclusion policy (1)

changes/fma-quit-relaunch-bundle-id-with-space

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Removed unnecessary comments from the quitAndTrackApplicationFunc definition.

coderabbitai · 2026-09-19T02:44:40Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: 37d8076
Latest commit, not reviewed: dae9eed

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: fleetdm/fleet/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 878818ce-d975-418b-a9da-9b37ef2d1d16

📥 Commits

Reviewing files that changed from the base of the PR and between 0a9ea91 and 37d8076.

📒 Files selected for processing: 1

ee/maintained-apps/inputs/homebrew/scripts/wispr-flow_install.sh

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review.

Walkthrough

The change updates generated Homebrew helpers and maintained macOS app installer scripts to derive running-state variable names by replacing characters outside the alphanumeric and underscore set with underscores. Quit and relaunch paths use the same derivation. Tests cover punctuation, spaces, eval round trips, command-substitution handling, and matching derivations. The changelog describes an app with a space in its bundle ID that did not relaunch after an update.

Priority: ⬇️ Low

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 37d80

The change consistently sanitizes the reported space-containing bundle ID when saving and reading application state. No concrete unresolved merge risk remains.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 38.24% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 34 functions across 16 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the macOS Fleet-maintained app relaunch fix for bundle IDs with invalid identifier characters.
Description check		The description provides the related issue context, explains the root cause and fix, documents affected behavior, lists automated and manual testing, records the unavailable lint command, and includes…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description provides the related issue context, explains the root cause and fix, documents affected behavior, lists automated and manual testing, records the unavailable lint command, and includes the required AI section. The completed checklist items are appropriate for this change.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

codecov · 2026-09-19T02:55:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (0fce4b8) to head (dae9eed).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #53570      +/-   ##
==========================================
- Coverage   77.37%   76.96%   -0.42%     
==========================================
  Files        4329     4282      -47     
  Lines      269975   266722    -3253     
  Branches    15957    14554    -1403     
==========================================
- Hits       208903   205284    -3619     
- Misses      60882    61259     +377     
+ Partials      190      179      -11

Flag	Coverage Δ
backend	`78.64% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…t-relaunch-varname-eval # Conflicts: # ee/maintained-apps/ingesters/homebrew/scripts_test.go

allenhouchins · 2026-10-08T18:07:25Z

/agentic_review

qodo-free-for-open-source-projects · 2026-10-08T18:10:03Z

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Pale Moon still fails to relaunch 🐞 Bug ≡ Correctness

Description

quitAndTrackApplicationFunc changes the generated script, but the checked-in Pale Moon manifest
still contains the old variable-name derivation in both functions. When that manifest installs an
update while Pale Moon is running, its bundle identifier still breaks the flag lookup, so the app is
quit and not reopened.

Code

ee/maintained-apps/ingesters/homebrew/scripts.go[822]
+  local var_name="APP_WAS_RUNNING_${bundle_id//[^[:alnum:]_]/_}"

Evidence
The affected input supplies the bundle identifier with a space, while its checked-in output still
uses tr '.-' '__' in both functions. The server fetches maintained-app manifests from the
published outputs, and the output-sync workflow runs on output changes; changing only the generator
does not replace the manifest this PR ships.
ee/maintained-apps/inputs/homebrew/pale-moon.json[2-5]
ee/maintained-apps/outputs/pale-moon/darwin.json[12-23]
server/mdm/maintainedapps/sync.go[204-217]
.github/workflows/sync-maintained-apps-outputs.yml[1-10]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The generator is fixed, but the checked-in Pale Moon manifest still ships the old install script, so this PR does not fix relaunches for users of that manifest.
## Fix Focus Areas
- ee/maintained-apps/ingesters/homebrew/scripts.go[820-822]
- ee/maintained-apps/ingesters/homebrew/scripts.go[874-876]
- ee/maintained-apps/outputs/pale-moon/darwin.json[12-23]
## Recommended Fix
Regenerate and commit the Pale Moon output using the updated generator. Verify its referenced install script uses the new derivation in both functions and that its script reference is updated.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Tip of the day

💡 Did you know, you can pick a display mode instead of tweaking every Display option by hand

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

**Related issue:** Part of #54170 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. - [x] Timeouts are implemented and retries are limited to avoid infinite loops ## Testing - [x] Added/updated automated tests - [ ] QA'd all new/changed functionality manually `TestInstallScriptStopsWhenAppWontQuit` runs generated install scripts (app copy and pkg) in bash with `osascript`, `sudo` and friends stubbed. It covers an app that isn't running, one that quits, one that accepts the quit event but keeps running, and one whose quit is canceled. The last two must exit 1 without copying or installing anything. The test fails against `main` and passes with this change. I also ran each edited custom install script end to end with stubs and a refused quit. All of them exit 1 before replacing the app, except Harmony SASE (see below). Docker Desktop's helper was checked under its `set -euo pipefail` for both outcomes. Not run on a real Mac. ## AI **AI:** Claude Code (claude-opus-5-5) ## Summary When a macOS app won't quit (for example, the user cancels a prompt to save changes), the install script moves it aside anyway, copies the new version in, and exits 0. fleetd then deletes `$TMPDIR`, which takes the moved-aside bundle the app is still running from. Fleet reports the update as installed while the user is still on the old version (#54170). Two problems in `quit_and_track_application` caused this: - It confirmed the quit with `pgrep -f "$bundle_id"`, which never matches because a macOS app's command line is its executable path. So it reported success as soon as the quit event was accepted. - When the app was still running at the timeout, it only logged "did not quit", and the caller carried on. Changes: - The helper now polls `osascript … is running` after each quit attempt and returns 1 at the timeout. This matches the KiCad FMA (#54613). An `is running` error doesn't count as quit. - Generated install scripts call `quit_and_track_application '<id>' || exit 1` before replacing the app, for both app-copy and pkg installs. - Custom install scripts that copy the helper get the same fix. Callers stop the install, and Pd detaches its disk image first. Docker Desktop already stopped on failure (it runs under `set -e`) and only needed the `pgrep` fix. **Harmony SASE** keeps going: its pkg force-quits the app on its own, so stopping would block an update that works today. - The `new-fma` skill now says how custom install scripts should quit the app and that helper copies must be kept in sync. Behavior change: a forced patch whose app won't quit now fails, and it's retried on the next policy run instead of being reported as installed. The yaml-files and REST API docs describe when the install is *attempted* ("whether or not the app is open"), which is still accurate, so they're unchanged. Outputs aren't regenerated here: like #43842 and #42951, the FMA bot picks up the new script refs. The 18 frozen macOS apps keep their current scripts until they're unfrozen. Follow-ups (not in this PR): - 12 custom install scripts have their own `quit_application` helper with the same `pgrep` check and no stop on failure: 1Password, Adobe Creative Cloud, Box Tools, ExpressVPN, Google Chrome, Grammarly, Gyazo, Logi Tune, Microsoft Edge, P4V, Slack, Zoom. Each has its own flow, so they need a per-script look. - The uninstall helper `quit_application` has the same `pgrep` check. It's left unchanged here to avoid churning every uninstall script ref. - #53570 changes the `var_name` line of the same helper, in a separate hunk. The Wispr Flow custom script in #54708 copies the old helper and needs this fix after whichever merges second.  ## Summary by CodeRabbit * **Bug Fixes** * On macOS, updates now stop if the app being replaced doesn’t quit within the timeout. The running app’s files are preserved, and the update is reported as failed rather than installed.

Firefox (release, developer edition, nightly) and KiCad custom install scripts landed on main with the old tr '.-' '__' derivation. Add a test so custom script copies can't reintroduce it.

…se, and Twobird freezes (#56136) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088. Carries every version, URL, hash, and input change from the 2026-10-20 nightly run, so the remaining split PRs are install-script regens only. - macOS nightly version bumps: 1Password 8.12.42, Kiro 1.4.10, MacWhisper 15.7, NetNewsWire 7.2.1, ocenaudio 3.22.1, OpenCode Desktop 2.1.1, Opera 138.0, Plex Media Server 1.43.5.11029, Rectangle 2.0.4, Spokenly 2.32.0, Superhuman Docs 1.0.14, Tableau 2026.3.0. - Windows nightly version bumps: AWS CLI 2.38.2, TablePlus 27.1.2. - MEGAsync 6.7.0 and Mobirise 6.1.17: pinned to the version the installer delivers, and the inputs are now frozen. Both download from version-less URLs (`sha256: no_check`) that now serve newer builds than their casks (6.6.2.0 and 6.1.12), so validation failed on #56088 with "App version ... was not found by osquery". I confirmed both versions by mounting the current DMGs. The unfreeze probe can lift the freezes once the casks catch up. - Twobird: input frozen, version unchanged (1.0.52), output carries the regenerated script. Cloudflare returns 403 to the GitHub macOS runners for `https://www.twobird.com/download/mac-arm64`, so validation failed here and on #55308. The same URL returns 200 from outside CI, including with Go's User-Agent. Freezing makes the validator skip it. Twobird hasn't had a version bump since it was added in June. The macOS outputs here also pick up the regenerated install script from #53570, except 1Password, which uses a custom install script. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed, non-frozen app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…s-vpn-client) (#56124) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 1 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `010-editor` through `aws-vpn-client` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…tcat) (#56133) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 10 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `pycharm` through `shortcat` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…thing-app) (#56134) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 11 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `shotcut` through `syncthing-app` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…gh devonthink) (#56126) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 3 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `claude-devtools` through `devonthink` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…through highlight-ai) (#56128) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 5 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `firefly-iota-desktop` through `highlight-ai` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. Front failed validation on #56088 with a DNS lookup error on the runner. The download resolves and returns 200 now, so a re-run should clear it if it recurs. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…lpaca) (#56127) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 4 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `devtoys` through `firealpaca` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…ar) (#56129) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 6 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `hive-app` through `linear` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…harm-ce) (#56132) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 9 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `opencloud` through `pycharm-ce` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…ix-workspace) (#56125) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 2 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `axure-rp` through `citrix-workspace` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. `chatgpt/darwin.json` is rebuilt on top of #55246, so it keeps the dual bundle ID queries already on main and only picks up the new script. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…installer) (#56130) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 7 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `linearmouse` through `minstaller` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. MenubarX failed validation on #56088 with a TLS handshake timeout on the runner. The download returns 200 now, so a re-run should clear it if it recurs. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…wift) (#56135) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 13 of 13). Regenerates the install scripts for the 61 macOS Fleet-maintained apps from `vnc-viewer` through `zwift` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…d) (#56131) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 8 of 13). Regenerates the install scripts for the 73 macOS Fleet-maintained apps from `miro` through `openboard` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

…ough vnc-server) (#56137) **Related issue:** N/A, nightly Fleet-maintained apps ingestion. Split from #56088 (part 12 of 13). Regenerates the install scripts for the 72 macOS Fleet-maintained apps from `syntax-highlight` through `vnc-server` (alphabetical by slug) after #53570 changed how the shared quit and relaunch helpers build their "was running" variable name, so bundle IDs with characters other than dots and dashes relaunch correctly. Every file in this PR gets the same change: a new `install_script_ref` and the regenerated script under `refs`. No versions, installer URLs, or hashes change here; those are in the bumps-and-freezes split. ## Split PRs from #56088 These touch disjoint files and can merge in any order. - #56136 Nightly version bumps; MEGAsync, Mobirise, and Twobird freezes - #56124 Script regen 1/13: 010-editor through aws-vpn-client - #56125 Script regen 2/13: axure-rp through citrix-workspace - #56126 Script regen 3/13: claude-devtools through devonthink - #56127 Script regen 4/13: devtoys through firealpaca - #56128 Script regen 5/13: firefly-iota-desktop through highlight-ai - #56129 Script regen 6/13: hive-app through linear - #56130 Script regen 7/13: linearmouse through minstaller - #56131 Script regen 8/13: miro through openboard - #56132 Script regen 9/13: opencloud through pycharm-ce - #56133 Script regen 10/13: pycharm through shortcat - #56134 Script regen 11/13: shotcut through syncthing-app - #56137 Script regen 12/13: syntax-highlight through vnc-server - #56135 Script regen 13/13: vnc-viewer through zwift # Checklist for submitter If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters. ## Testing - [ ] QA'd all new/changed functionality manually The darwin FMA validator runs against every changed app in this PR. ## AI **AI:** Claude Code (claude-opus-5-5)

Install: apply #53570's var_name derivation to quit_and_track_application and relaunch_application, so the copies match scripts.go byte-for-byte. For com.github.wez.wezterm the derived name is unchanged. Uninstall: rebuild wezterm-uninstall.sh from the current generator (#56457) with only the rm -rf path changed to /Applications/WezTerm.app. It picks up the login-window-safe trash() that TestCustomUninstallScriptsUseCurrentTrash requires, and quit_application 'com.github.wez.wezterm' || exit 1 before the bundle is removed. trash() now skips ~ paths with no GUI user, so the LOGGED_IN_USER guard around the calls is no longer needed. WezTerm is frozen, so swap the embedded scripts and refs in darwin.json by hand: install 056ac45d -> 57c7d5cf, uninstall fce4539f -> 4db160b2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI lite review requested due to automatic review settings September 19, 2026 02:31

allenhouchins requested a review from a team as a code owner September 19, 2026 02:31

allenhouchins had a problem deploying to Docker Hub September 19, 2026 02:31 — with GitHub Actions Error

Copilot started reviewing on behalf of allenhouchins September 19, 2026 02:31

View session

Copilot AI reviewed Sep 19, 2026

View reviewed changes

Comment thread ee/maintained-apps/ingesters/homebrew/scripts.go Resolved

Trim comments

f633dd6

allenhouchins had a problem deploying to Docker Hub September 19, 2026 02:35 — with GitHub Actions Error

Clean up comments in quitAndTrackApplicationFunc

a1cda8b

Removed unnecessary comments from the quitAndTrackApplicationFunc definition.

allenhouchins temporarily deployed to Docker Hub September 19, 2026 02:36 — with GitHub Actions Inactive

allenhouchins mentioned this pull request Sep 19, 2026

Escape UniqueIdentifier in FMA quit/relaunch script generation #53566

Closed

2 tasks

allenhouchins assigned lukeheath Oct 5, 2026

lukeheath previously approved these changes Oct 6, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into allenhouchins/fma-qui…

d43b325

…t-relaunch-varname-eval # Conflicts: # ee/maintained-apps/ingesters/homebrew/scripts_test.go

allenhouchins dismissed lukeheath’s stale review via d43b325 October 7, 2026 01:43

allenhouchins temporarily deployed to Docker Hub October 7, 2026 01:43 — with GitHub Actions Inactive

Merge branch 'main' into allenhouchins/fma-quit-relaunch-varname-eval

3cf47dc

allenhouchins temporarily deployed to Docker Hub October 8, 2026 17:23 — with GitHub Actions Inactive

allenhouchins marked this pull request as draft October 8, 2026 17:23

qodo-free-for-open-source-projects Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread ee/maintained-apps/ingesters/homebrew/scripts.go Resolved

allenhouchins mentioned this pull request Oct 8, 2026

Stop macOS FMA installs when the app won't quit #55157

Merged

4 of 5 tasks

allenhouchins added 2 commits October 9, 2026 21:00

Merge remote-tracking branch 'origin/main' into pr-53570-work

09aa2b1

Apply bundle ID var-name fix to custom scripts added since branching

26ec4e0

Firefox (release, developer edition, nightly) and KiCad custom install scripts landed on main with the old tr '.-' '__' derivation. Add a test so custom script copies can't reintroduce it.

allenhouchins temporarily deployed to Docker Hub October 10, 2026 02:02 — with GitHub Actions Inactive

allenhouchins marked this pull request as ready for review October 10, 2026 02:26

This was referenced Nov 1, 2026

Fix Sequel Ace (macOS) Fleet-maintained app bundle ID #57121

Closed

Relaunch Slack (macOS) after a Fleet-maintained app update #57175

Merged

Navigation Menu

Repository navigation

Fix macOS FMA relaunch for bundle IDs with non-identifier characters - #53570

Fix macOS FMA relaunch for bundle IDs with non-identifier characters#53570
allenhouchins merged 11 commits into
mainfrom
allenhouchins/fma-quit-relaunch-varname-eval

allenhouchins commented Sep 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

Reviews paused

Uh oh!

codecov Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

allenhouchins commented Oct 8, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

allenhouchins commented Sep 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist for submitter

What & why

Reviewer notes

Testing

AI

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Uh oh!

codecov Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

allenhouchins commented Oct 8, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allenhouchins commented Sep 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 19, 2026 •

edited

Loading

codecov Bot commented Sep 19, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Oct 8, 2026 •

edited

Loading