镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(cli): clearer desktop pairing errors, paired default relay, and auth desktop list - #9196

Merged
wpfleger96 merged 8 commits into
mainfrom
wpfleger/cli-pairing-cleanup
Nov 6, 2026
Merged

wpfleger96 merged 8 commits into
mainfrom
wpfleger/cli-pairing-cleanup

Conversation

@wpfleger96

@wpfleger96 wpfleger96 commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Follow-ups to the CLI's Buzz desktop credential support, for a person running the CLI with a desktop pairing.

  • The "no credentials" error names the relay. It says which relay the CLI tried and which relays this CLI is paired for, and tells you to pass --relay. When a pairing exists for that relay but no running desktop accepts it, it says so instead.
  • Default relay for a paired person. With no --relay, no BUZZ_RELAY_URL, no inherited agent credential and no explicit key, the CLI uses the one relay that a running desktop still accepts this CLI's pairing for, confirmed by describe on a same-user connection. Stored pairings alone never count. With zero or several such relays, the default stays http://localhost:3000. A desktop's refusal fails the command with its message. When another paired desktop's check fails (its same-user check times out or can't confirm the owner, or it stays rate limited), the command fails rather than pick a relay, even if one other relay was accepted, since that desktop may accept a relay of its own; a timeout or exhausted throttle fails with a retryable error. auth desktop unpair never runs discovery, and auth desktop pair never asks other desktops for their pairings, so one desktop's refusal can't block pairing another. Help text updated.
  • buzz auth desktop list. Lists each pairing's instance, relays and pubkey, with accepted, not accepted (revoked or no longer bound), not running, unconfirmed, rate limited or refused (the last three with an error), using the same check as the default relay. Desktops are asked at once, without waiting out throttling. It never prints tokens, needs no relay, prints [] with no pairings, and --format compact drops the pubkey.
  • Retryable same-user timeout. When a paired desktop's same-user check times out and nothing else serves, the command now fails with a retryable unavailable error (exit 2) instead of "no credentials" (exit 3).
  • Regression tests for the NIP-42 AUTH event naming the relay with its trailing slash, for skipping a paired desktop whose user can't be confirmed, without sending it anything, and for relay selection never asking desktops for pairings with an explicit key, auth desktop pair or auth desktop unpair, or over an inherited agent relay.

…ing, list pairings

Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@wpfleger96
wpfleger96 requested a review from a team as a code owner November 6, 2026 16:39
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 744f3946f6fe1ff7a649c132638d5af608900dbd...d9b63b2e3eda72fe1ea2fc4df5449096debdaef7
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability regressions found in the authorized PR range.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source and history inspection. Builds and tests were not run, as requested.

Generated by Codex Security Review |
Requested by: @wpfleger96 |
Workflow run

Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
… response seams

Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@github-actions github-actions Bot added codex-security-review-current The posted Codex security review matches its recorded range. and removed codex-security-review-current The posted Codex security review matches its recorded range. labels Nov 6, 2026

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Two P2 defects remain: agent recovery guidance can select the owner's identity, and an unrelated desktop refusal blocks targeted pairing. Please address these before approval.

Comment thread crates/buzz-cli/src/client.rs Resolved
Comment thread crates/buzz-cli/src/lib.rs Resolved
wpfleger96 and others added 3 commits November 6, 2026 12:56
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
…cleanup

* origin/main:
  feat(cli): manage sidebar sections with `buzz sidebar sections` (#9191)
  Show mobile floating dates while scrolling (#9185)
  fix(relay): regenerate missing image thumbnails on request (#9174)
  feat(loadgen): model agent turns and sustained holds (#9182)

Signed-off-by: Will Pfleger <wpfleger@block.xyz>
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

@TheSentinel454 TheSentinel454 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 One P1 and one test gap below.

Comment thread crates/buzz-cli/src/desktop_provider.rs Resolved
Comment thread crates/buzz-cli/src/lib.rs Resolved
A paired desktop that was throttled, timed out, or whose owner couldn't be confirmed might accept a relay of its own, so one accepted relay elsewhere is not yet the only one.

Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026

@TheSentinel454 TheSentinel454 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM at d9b63b2. Both comments addressed.

@wpfleger96
wpfleger96 enabled auto-merge (squash) November 6, 2026 18:54
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
@wpfleger96
wpfleger96 merged commit c8d7366 into main Nov 6, 2026
90 checks passed
@wpfleger96
wpfleger96 deleted the wpfleger/cli-pairing-cleanup branch November 6, 2026 19:11
bradseiler added a commit that referenced this pull request Nov 6, 2026
* origin/main:
  fix(relay): route live REQ events by each filter's own channel scope (#8519)
  fix(relay): deliver multi-node fan-out concurrently and never drop silently (#9195)
  perf(db): bound since-limited events reads with the month-floor literal (#9197)
  fix(mobile): match Agents sign-in to Home’s reconnect capsule (#9204)
  fix(cli): clearer desktop pairing errors, paired default relay, and auth desktop list (#9196)

Signed-off-by: Brad Seiler <seiler@squareup.com>

This branch was previously deployed

1 inactive deployment
codex-review — d9b63b2e Deployed Nov 6, 2026 by wpfleger96 via Run Codex Security Review #13569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants