Repository navigation
fix(cli): clearer desktop pairing errors, paired default relay, and auth desktop list - #9196
Conversation
…ing, list pairings Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Signed-off-by: Will Pfleger <wpfleger@block.xyz>
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Signed-off-by: Will Pfleger <wpfleger@block.xyz>
… response seams Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Signed-off-by: Will Pfleger <wpfleger@block.xyz>
kalvinnchau
left a comment
There was a problem hiding this comment.
🤖 Two P2 defects remain: agent recovery guidance can select the owner's identity, and an unrelated desktop refusal blocks targeted pairing. Please address these before approval.
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Signed-off-by: Will Pfleger <wpfleger@block.xyz>
…cleanup * origin/main: feat(cli): manage sidebar sections with `buzz sidebar sections` (#9191) Show mobile floating dates while scrolling (#9185) fix(relay): regenerate missing image thumbnails on request (#9174) feat(loadgen): model agent turns and sustained holds (#9182) Signed-off-by: Will Pfleger <wpfleger@block.xyz>
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Signed-off-by: Will Pfleger <wpfleger@block.xyz>
Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Signed-off-by: Will Pfleger <wpfleger@block.xyz>
TheSentinel454
left a comment
There was a problem hiding this comment.
🤖 One P1 and one test gap below.
A paired desktop that was throttled, timed out, or whose owner couldn't be confirmed might accept a relay of its own, so one accepted relay elsewhere is not yet the only one. Signed-off-by: Will Pfleger <wpfleger@block.xyz>
TheSentinel454
left a comment
There was a problem hiding this comment.
🤖 LGTM at d9b63b2. Both comments addressed.
* origin/main: fix(relay): route live REQ events by each filter's own channel scope (#8519) fix(relay): deliver multi-node fan-out concurrently and never drop silently (#9195) perf(db): bound since-limited events reads with the month-floor literal (#9197) fix(mobile): match Agents sign-in to Home’s reconnect capsule (#9204) fix(cli): clearer desktop pairing errors, paired default relay, and auth desktop list (#9196) Signed-off-by: Brad Seiler <seiler@squareup.com>
Follow-ups to the CLI's Buzz desktop credential support, for a person running the CLI with a desktop pairing.
--relay. When a pairing exists for that relay but no running desktop accepts it, it says so instead.--relay, noBUZZ_RELAY_URL, no inherited agent credential and no explicit key, the CLI uses the one relay that a running desktop still accepts this CLI's pairing for, confirmed bydescribeon a same-user connection. Stored pairings alone never count. With zero or several such relays, the default stayshttp://localhost:3000. A desktop's refusal fails the command with its message. When another paired desktop's check fails (its same-user check times out or can't confirm the owner, or it stays rate limited), the command fails rather than pick a relay, even if one other relay was accepted, since that desktop may accept a relay of its own; a timeout or exhausted throttle fails with a retryable error.auth desktop unpairnever runs discovery, andauth desktop pairnever asks other desktops for their pairings, so one desktop's refusal can't block pairing another. Help text updated.buzz auth desktop list. Lists each pairing's instance, relays and pubkey, withaccepted,not accepted(revoked or no longer bound),not running,unconfirmed,rate limitedorrefused(the last three with anerror), using the same check as the default relay. Desktops are asked at once, without waiting out throttling. It never prints tokens, needs no relay, prints[]with no pairings, and--format compactdrops the pubkey.unavailableerror (exit 2) instead of "no credentials" (exit 3).auth desktop pairorauth desktop unpair, or over an inherited agent relay.