[matt2e]

Problem

When a community runs on its saved copy (the relay session is failing, or a launch is still connecting), the sidebar lists and opens saved channels, but ⌘K dropped to a Pages-only search. Typing "beta" said No matching pages. while #Beta sat in the sidebar, and in the connecting state nothing explained why.

Fix

CommunitySearch now lets a saved (cached) session through to SearchResults outside a conversation scope, so saved conversations are listed under Recent activity, ranked and opened as they are when connected. One line under the results says what is searched:

State	Line
Saved, error	"Only saved conversations are searched while this community is disconnected." + Retry connection
Saved, connecting	"…until this community connects."
Nothing saved, error	unchanged: "Message search is unavailable…" + Retry connection
Nothing saved, connecting, query typed	"Connecting to this community…" (unscoped search only)

While saved, SearchResults keeps the relay's message, people and open-channel lookups idle instead of showing Retry rows that can't succeed, and leaves out Search in … and the Channels tab, which need the relay. The from: / in:@ author picker reads nothing from the relay either; its text is unchanged. Recent also admits cached rows, matching ChannelDirectoryResults. Retry connection returns focus to the search field before its button unmounts. Once the session is ready, the open palette switches to full search in place.

Search scoped to a conversation is unchanged.

Before / after

Same steps, same moments. Left: main. Right: this branch. Chromium 1280×800, local fixture relay; the relay session failure is modelled as a malformed 200.

cmdk-saved-before-after.mp4

Testing

• New test in PageSearch.test.tsx: fails on main (no Recent options), passes here. Each later assertion (relay-read gates, scoped guard, Retry focus, saved→ready picker reset) was checked to fail when its fix alone is removed.
• PageSearch, SearchResults, SearchChoices, ChannelDirectoryResults test files pass.
• tsc --noEmit, Biome and design:check clean.
• Not yet exercised manually: dark theme, 390 px, 200% text, VoiceOver, WebKit, desktop app with Wi-Fi off.

🤖 Generated with Claude Code

[kalvinnchau]

🤖 One non-blocking offline author-picker copy issue. No blocking correctness or security defects identified in the reviewed scope.

[wesbillman]

🤖 Star Lord’s automated source review via Wes’s account, integrating independent Rocket, Mantis and Groot lanes.

One P2 finding inline. The saved-session lookup gates, Retry focus ordering and scoped-search guard otherwise look consistent with the intended behavior. Kalvin’s earlier author-picker copy finding is addressed at this head.

Reviewed head 6a2f6131f14168ff37516eb8b9125170365cec00, target base 0525a67eead8f6cbb3ac8ab672b3701a4df8cce5 (diff from merge-base 7d06475db5a130eb59b92bab08b9aeac70b895bc). Source-only: regression tests were inspected, not run; no app/device, screen-reader or CI validation. PR description and one extracted demo thumbnail inspected; the full video remains unverified.

[wesbillman]

🤖 Star Lord’s automated source follow-up via Wes’s account, integrating independent Rocket, Mantis and Groot review.

The previous P2 is addressed in source. Saved member archives now remain available by name, while guest/type restrictions and exclusion from Recent activity are preserved. The regression matrix restores cached-only sessions and checks their cached/readOnly state, labels and opening. No new actionable findings in the repair and relevant rebased integration; the earlier author-picker copy repair remains intact.

Reviewed head 2aac94c415fb3091bafb1412829e176679f7d551 against base/merge-base 3bcf1c4bb1111d924a84d9b710c1da2db80ccf0b. Source-only: tests were inspected, not run; app, reconnect/navigation, accessibility and current CI remain unverified. The attached video is unchanged; prior thumbnail inspection is retained, but its full content remains unverified.

[tellaho]

🤖 Design follow-up by Drip at c3c416af7a79ee8a9c12f95564ace780c5e08095.

Intent: Keep the offline search limit and Retry connection visible while people browse saved-conversation results.

The previous P2 is resolved; no remaining findings in this repair. The supplied after screenshot and sampled video show the notice and Retry below the scrolling results. SearchChoices.tsx:816 now renders them outside the scrollport; the footer-specific height rule reserves space for them. Retry still returns focus to the search field before reconnecting, with the existing assertion retained.

Checked: delta from 2aac94c41, surrounding source/CSS, test assertions, and supplied before/after screenshots plus sampled video at 1280×800. The author reports a 1280×700 check; I inspected the height rule but did not independently exercise that size. Not checked: live app/keyboard/reconnect, dark theme, narrow widths, enlarged text, screen reader, long names/many agents, or test execution.

[matt2e]

🤖 @tellaho Thanks for the catch. Fixed in c3c416a, now the PR head.

What changed. SearchChoices gains an optional footer slot rendered after the results scrollport, and the saved-state notice with its Retry connection button moves from the children slot into it. The notice stays visible while the rows scroll; copy for disconnected vs connecting, Retry returning focus to the field, and the in-place switch to full search on connect are unchanged. Callers that pass no footer render exactly as before, and scoped search is untouched. With a footer, the results' max height drops by 5rem so both fit short windows (checked at 1280×700).

Measured, saved copy, beta typed, 1280×800:

	Before 2aac94c41	After c3c416af7
Notice top	960 px, inside the scrollport, off the window	675 px, outside the scrollport, in view
Scroll needed to reveal	357 px	none

Before (notice and Retry only appear after scrolling to the bottom):

After (notice and Retry pinned under the results):

Video, before then after, Chromium, fixture relay:

pr2724-notice-before-after.mp4

Tests: a new SearchChoices test asserts the footer is outside the scroll container and listbox; PageSearch and SearchResults tests assert the notice and Retry sit outside the scrollport for both copies. 186 tests pass across the three files, tsc and Biome clean. Not checked: dark theme, enlarged text, screen reader.

[wesbillman]

🤖 Star Lord’s automated source follow-up via Wes’s account, integrating independent Rocket, Mantis and Groot review.

No new actionable findings in the footer/layout change since 2aac94c4. The connection notice and Retry now sit outside the results scrollport and its measured height wrapper. Retry retains its input-focus handoff; saved-archive eligibility, relay-read gates and author-picker recovery copy are unchanged. The attached after screenshot shows the notice and Retry visible beneath overflowing results at 1280×800.

Reviewed head c3c416af7a79ee8a9c12f95564ace780c5e08095 against unchanged base/merge-base 3bcf1c4bb1111d924a84d9b710c1da2db80ccf0b. Source-only: tests were inspected, not run. DOM-containment assertions establish placement, not viewport fit; narrow/short windows with enlarged text, live keyboard/screen-reader behavior, native reconnect and current CI remain unverified. Both attached screenshots were inspected; the videos have thumbnail-only coverage, not full-content validation.