[matt2e]

Two summaries of what needs your attention got mentions wrong. The sidebar Activity popover listed only unread thread replies, so a top-level @mention never appeared in it: a channel with only a mention opened no popover, and a mention next to an unread thread left no trace. The sidebar Inbox card's header counted any conversation that had ever mentioned you as an unread mention, and gave Solo rows no kind, so its numbers disagreed with the Inbox page.

Activity now lists a channel's unread top-level mentions under Mentions, above Unread threads, and the single dot's label names both. The Inbox card leads with the total and counts a mention only while it is unread.

Before / after

attention-sbs.mp4

Left is main @ b621738, right is this branch @ f404497. Both halves run the same flow with the same fixture data, and each step is padded to a fixed time so they stay aligned. Every claim on screen is checked by an assertion in that half.

• Part 1, #Launch: a top-level mention arrives, then 30 more messages. Left: hovering the row opens nothing, and the Inbox row stays unread. Right: hovering opens "Activity in Launch" with a Mentions section; clicking the mention reveals it mid-channel, reads it, and the dot and Inbox unread mark clear.
• Part 1, #Beta: a mention arrives next to an unread thread. Left: the dot label stays "1 unread thread" and the popover lists only Unread threads. Right: the label reads "1 unread mention, 1 unread thread" and Mentions sits above Unread threads. Both sides have one dot.
• Part 2, Inbox card: a thread reply that mentions you plus a message in your own Solo chat. Left: "1 mention unread", and after both are read and a plain reply arrives, "1 mention unread" again while Inbox → Mentions with Unread only is empty. Right: "2 unread · 1 mention", then "1 unread", then "1 unread · 1 thread".

Recorded in Chromium at 1280×800 with synthetic fixture data.

What changed

Four commits, each landable on its own review.

• fix(inbox): the card counts unread mentions and leads with the total (InboxPreview.tsx, +5/−3)
  • The header reads "N unread · kinds". Each conversation counts once under its most specific kind: DM, then mention, then thread. A Solo chat's flat row has no kind, so only the total counts it.
  • A mention counts only while its mention-only view is unread, which is what the page's Mentions filter with Unread only lists. item.mentioned keeps meaning "ever mentioned", because the page uses it to list read mentions too.
  • The header stays plain text; clickable counts are a separate decision.
• feat(channels): Activity lists unread top-level mentions
  • unread.ts: ThreadActivitySnapshot gains an optional mentions list (MentionActivityItem), newest first. In computeActivity, top-level entries (no thread reference at all, not just no root) take a branch before the reply skip: listed when category() is "mention" and the message is unread. DMs are "direct", so they never have one; broadcasts alone and mentions inside replies are left out. equalActivity compares mentions, so an unrelated publish keeps the snapshot's identity.
  • ChannelActivityPopover.tsx: ActivityRow takes a noun, an open handler and a read function. A Mentions section reuses the section heading. hasActivity, the stale check, the hover gate and the profile prefetch include mentions, so a mention-only row opens on hover, focus + Enter and click. Mark read writes a message mark; on failure the row shows "Could not mark this mention as read. Try again." Revealing the popover reads nothing.
  • UnreadBadge.tsx: still one dot. Its label and title read "1 unread mention, 1 unread thread". A row with only mentions keeps its priority dot, which already looks the same.
  • Open wiring: ChannelSidebarItem gets onOpenMessage(channelId, messageId); ChannelInventory passes openActivityMessage, and SoloInventory uses its openMessage. A mention opens with no thread root. Once fix(channels): open the unread reply from sidebar Activity #2555 lands, this folds into its widened (channelId, messageId, rootId?) callback.
• fix(messages): read a revealed row that lands a sub-pixel past the edge (use-reading.ts)
  • Opening an off-screen message exactly, such as a mention from Activity, revealed and focused it but never read it. Scroll offsets snap to whole pixels while rows sit at fractional ones, so scrollIntoView({ block: "start" }) left the row 0.047px above the scroller (top 96.953 against 97, in Chromium and WebKit), and shown() required the row to be strictly inside. It stayed unread, and stayed in Activity, until the reader scrolled.
  • shown() now allows one pixel at each edge, like the 1px slack the bottom check already uses. Bottom catch-up is unchanged. This also fixes message links to an off-screen message.
  • Known and unchanged: the floating typing/activity indicators and the jump-to-latest button sit over the bottom of the scroller, and shown() has never allowed for them; the extra pixel makes no difference to that.
• fix(channels): announce a mention-only row's mentions to assistive tech (UnreadBadge.tsx)
  • The priority dot is aria-hidden and the activity label rendered only with a thread, so a mention-only row read "Beta 1 observed unread messages. Not an exact total." It now adds a screen-reader-only "N unread mention(s)", muted or not; with a thread, the dot's label already names both. onOpenMessage becomes required.

Docs: docs/inbox.md (the header rule), docs/unread.md (Mentions in the popover, one dot, the pixel tolerance, muted rows), docs/buzz-help.md (a "Sidebar activity" bullet).

Not in this PR

• A caught-up reader still lands at the bottom, and that bottom catch-up still reads an off-screen mention (docs/unread.md, bottom-edge catch-up). Landing at the "New messages" divider instead needs a product call and stacks after fix(channels): keep the reader's place when Back returns to a link-opened channel #2500 and fix(channels): open a thread's channel at its root message from the #channel link #2377.
• Clickable card counts, pending the same decision.
• A mention can open as a lone message tab if the channel's messages haven't loaded yet and a cached window briefly answers. That's main's open path.
• A reply whose thread root can't be resolved is listed in neither section, as before; the row's priority dot still shows.
• Top-level @channel/@here messages are not listed under Mentions, matching the Inbox's Mentions filter.

Tests

Every new test fails without its production change.

• InboxPage.test.tsx: a new case walks the header through "3 unread · 1 mention · 1 thread" → "1 unread" (Solo alone) → "2 unread · 1 mention" → "Nothing unread" → "1 unread · 1 thread" after a plain reply. On the old code it reads "1 mention · 1 thread unread"; a wording-only change that still counts item.mentioned fails at the last step with "1 unread · 1 mention". Three existing strings updated.
• unread.test.ts: mentions in the snapshot, newest first, with a broadcast and a reply's mention excluded and a DM's list empty; Mark read; a quiet audience=agents mention never listed; a mention with a quote or unmarked e tag still listed; activity("room") keeps its identity through an unrelated publish.
• ChannelActivityPopover.test.tsx, ChannelSidebarMenuItem.test.tsx (dot label; mention-only label muted and unmuted, and gone once a thread arrives), ChannelInventory.test.tsx and SoloInventory.test.tsx (a mention opens with no thread root), use-reading.test.ts (rows 0.047px above the top or 0.5px below the bottom count as seen; 1.5px past either edge don't).
• tests/browser/thread-unread.spec.mjs, "top-level mention activity": a mention-only row opens Activity, and opening its mention reads it; opening a mention above the bottom from Activity reveals and focuses it without scrolling to the bottom, reads it, removes it from the popover and clears its Inbox row. Both fail on main in Chromium and WebKit; 20/20 repeats with the fix.
• Runs: tsc --noEmit, lint and format clean; full vitest 17,917 passed, 29 skipped; 224/224 across 18 reading and reveal browser specs in both engines.
• Not run: the full browser suite, the native app, VoiceOver, and the design checks in both themes, narrow and wide, at 200% text.

Landing

• Independent of fix(channels): open the unread reply from sidebar Activity #2555, which is still open; rebase whichever lands second (the mention wiring is a mechanical fold). feat(solo): keep shared chats quiet until you're tagged #2060 edits the same computeActivity condition; the new top-level branch sits above it.
• feat(inbox): rename to Activity and simplify the filter bar #2543 (Inbox → Activity rename) touches InboxPreview imports and strings, not the count loop.

🤖 Generated with Claude Code

[wesbillman]

🤖 Star Lord’s automated source review via Wes’s account, integrating independent Rocket, Mantis and Groot coverage.

Reviewed head a3e796e19b2f10692eefb60bd49f3cead07e01ab against base fb9cd7cf45c6d80368cc79a7c34535f8f3b2fd20. One P2 finding is attached inline: the new mention preview needs to honor the existing incomplete edit/deletion state. The review covered activity snapshots, Channels/Solo navigation, read-mark isolation, visibility tolerance, accessible labels, Inbox counts and regression-test source, preserving the documented non-goals.

Source-only: no tests, builds or app flows were executed, and author-reported results were not independently reproduced. The PR description and sampled frames across its 87.68-second demo were inspected; the recording identifies an earlier branch revision and is not current-head validation. Native behavior, assistive technology and the full theme/size matrix remain unverified.

[kalvinnchau]

🤖 One browser-test regression blocks required CI.

[wesbillman]

🤖 Star Lord automated source review via Wes’s account, integrating independent Rocket, Mantis and Groot review lanes.

Focused follow-up at a699b471922f51bef6ac44ff102b76410bd9ac42 against base/merge-base 3bcf1c4bb1111d924a84d9b710c1da2db80ccf0b: no new actionable findings.

The prior top-level mention preview finding is addressed: mention rows subscribe to the existing Inbox feed and share its incomplete-preview rule for both visible text and accessible names. The new mounted regression covers a held overlay read, failure, retry and recovery. The repaired browser selectors match the current Activity page and list labels, addressing the other review’s selector concern. The rebased reveal/navigation context preserves ordinary sidebar mention opening.

This is a source-only repair review, retaining prior coverage of the unchanged feature patches. Tests, builds, current CI and app flows were not run or independently verified. The unchanged demo was inspected through historical sampled frames, not as validation of this head. No approval or merge recommendation is implied.

[kazemek21]

🤖 Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

[morgmart]

🤖 Design review (Design Reviewer agent, head b6d0800)

Looks good from a design standpoint. A top-level mention now shows in the sidebar Activity popover, and the Inbox card counts only unread mentions, so both match what people actually need to look at. No must-fix issues.

Optional: with mentions and unread threads in one popover, check that the two read as clearly different groups, and that a channel with many mentions doesn't push threads out of view.

Not checked: I didn't run the app, so I didn't check dark mode, narrow windows, or busy channels with many agents mentioning you.

[wesbillman]

🤖 Star Lord automated source review via Wes’s account, integrating independent Rocket, Mantis and Groot review lanes.

Integration follow-up at b6d0800d63ac7f1dca77254adce8b7c88516b251 against base/merge-base cae3922574c5c1f0ce5d32231810229e94b1bb40: no new actionable findings.

The six previously reviewed feature patches are retained. The Solo callback and shared message-row adaptations preserve exact-message navigation and safe visible/accessibility previews. The earlier incomplete-preview P2 repair and Activity selector repair remain intact. We checked their interaction with the updated reading-observer lifetime, DM thread read boundaries, copied catch-up evidence and profile-owner cache invalidation, along with the relevant regression-test source. Documented non-goals remain unchanged.

Source-only: no tests, builds or app flows were run; performance and current CI were not independently verified. The current PR description and sampled demo frames were inspected; the attachment is unchanged and records earlier revisions, so it does not validate this head. Native behavior, assistive technology and the theme/size matrix remain unverified.

[wesbillman]

🤖 Star Lord automated source review via Wes’s account, integrating independent Rocket, Mantis and Groot coverage.

Integration follow-up at d1c91d1e5a536e868094923bc261e090d5ccdc20 against base/merge-base 5d9d1ef33c9fb3127497c2ecfba9819c0ebf9826: one low-priority P3 is attached inline. The new mention label uses retained unread totals while the rebased sidebar uses unseen row counts.

The six feature patches and prior incomplete-preview and Activity-selector repairs remain intact. The review checked their interaction with channel visits, foreground/background seen receipts, explicit unread intent, snapshot invalidation, retained Activity/Inbox counts and the mention browser journeys. Documented non-goals are preserved.

Source-only: no tests, builds or app flows were run; current CI and performance were not verified. The current description and historical sampled demo frames were inspected; the recording shows earlier revisions and does not validate this head. Native behavior, assistive technology and the theme/size matrix remain unverified.

[wesbillman]

🤖 [P3] Derive the mention label from the row’s unseen evidence

This count bypasses the new snapshot.row filtering used by count, attentionCount and threadCount. After an active channel visit quiets two off-screen mentions without reading them, a later ordinary message makes the badge render again: it can announce “1 observed unread messages” followed by “2 unread mentions”, despite having no priority dot. A new unseen thread likewise restores the already-seen mentions in the combined label; label-bearing Solo rows can retain the mention text even while otherwise quiet. This conflicts with the sidebar-following-row contract in docs/unread.md:93–100; the popover retaining those unread mentions is correct.

Count top-level mentions that pass the existing rowCut check in the unread owner (alongside row.threadCount), include that field in snapshot equality, and use it here with the full-activity fallback when row is absent for explicit unread intent. Cover seen mention → ordinary arrival and seen mention → new thread in the mounted label tests, while preserving the mention in the popover. This is a source-inferred accessibility/count inconsistency, not a runtime reproduction.