镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix(acp): count grouped thinking levels when checking a synced level - #2640

Merged
wpfleger96 merged 2 commits into
mainfrom
hayt/acp-grouped-thinking-levels
Nov 5, 2026
Merged

fix(acp): count grouped thinking levels when checking a synced level#2640
wpfleger96 merged 2 commits into
mainfrom
hayt/acp-grouped-thinking-levels

Conversation

@wpfleger96

@wpfleger96 wpfleger96 commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

ACP harnesses may list a thought_level select's choices inside option groups. Both places that read Goose's thinking levels only read top-level options[].value, so grouped levels were dropped:

  • Runtime: the shared session client checks a synced thinking level against the levels it read. A Goose turn whose synced level sat inside a group was refused before its prompt with "isn't offered".
  • Setup: Goose's model and thinking-level discovery passed undefined levels to the picker, which then failed formatting their labels.

Changes:

  • AcpSession.offer() flattens option groups with a shared valuesOf() helper, and Goose setup's level discovery uses the same helper.
  • The Goose test fake can list its levels in one group. New tests check that setup reads grouped levels, that a grouped synced level runs its prompt, and that a grouped level that is already current runs without sending a setter. All three fail without the fix.

@wpfleger96
fix(acp): count grouped thinking levels when checking a synced level
bae84ab 
Co-authored-by: Will Pfleger <wpfleger@block.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@wpfleger96
wpfleger96 requested a review from a team as a code owner November 5, 2026 17:43
kalvinnchau
kalvinnchau reviewed Nov 5, 2026
View reviewed changes

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 One remaining grouped-level compatibility gap; reproduced with modeled ACP output.

Comment thread src/features/agent-harness/acp/session.ts Resolved
@wpfleger96
fix(goose): read grouped thinking levels in setup
5482594 
Co-authored-by: Will Pfleger <wpfleger@block.xyz>
Signed-off-by: Will Pfleger <wpfleger@block.xyz>
@wpfleger96
wpfleger96 merged commit e9b94a6 into main Nov 5, 2026
43 checks passed
@wpfleger96
wpfleger96 deleted the hayt/acp-grouped-thinking-levels branch November 5, 2026 18:35
johnmatthewtennant added a commit that referenced this pull request Nov 5, 2026
@johnmatthewtennant
Merge origin/main into jtennant/simone/webp-thumbnails
33486f3 
Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz>

* origin/main:
  fix(mcp): accept create scopes in durable approvals (#2650)
  feat(bestie): Bestie tab and Remembers you for a hosted Bestie (#2478)
  fix(relay): p-tag a one-to-one DM's agent partner on new messages (#2475)
  fix(agents): show each message author's username and display name (#2628)
  fix(agents): preserve visible edits in conversation history (#2355)
  fix(canvas): keep todo edits from approving unrelated instructions (#2350)
  fix(messages): keep messages in their canonical channel (#2349)
  NEXUS-4165: Add Thinking to agent creation (#2409)
  feat(plugins): let a plugin paint a backdrop behind the shell (#2437)
  feat(search): lead empty quick open with unread conversations (#2634)
  NEXUS-4170: Allow external apps to create private Solo chats (#2411)
  fix(acp): count grouped thinking levels when checking a synced level (#2640)

Signed-off-by: John Tennant <jtennant@squareup.com>
agude-sq added a commit to agude-sq/buzz-app that referenced this pull request Nov 5, 2026
@agude-sq
Merge remote-tracking branch 'origin/main' into agude/prefer-full-names
da3998c 
* origin/main: (28 commits)
  fix(mcp): accept create scopes in durable approvals (block#2650)
  feat(bestie): Bestie tab and Remembers you for a hosted Bestie (block#2478)
  fix(relay): p-tag a one-to-one DM's agent partner on new messages (block#2475)
  fix(agents): show each message author's username and display name (block#2628)
  fix(agents): preserve visible edits in conversation history (block#2355)
  fix(canvas): keep todo edits from approving unrelated instructions (block#2350)
  fix(messages): keep messages in their canonical channel (block#2349)
  NEXUS-4165: Add Thinking to agent creation (block#2409)
  feat(plugins): let a plugin paint a backdrop behind the shell (block#2437)
  feat(search): lead empty quick open with unread conversations (block#2634)
  NEXUS-4170: Allow external apps to create private Solo chats (block#2411)
  fix(acp): count grouped thinking levels when checking a synced level (block#2640)
  feat(conversation): let plugin rows manage messages without visiting a channel (block#2512)
  feat(github): make side-panel link opening optional (block#2629)
  feat(messages): show a blurred thumbnail until an image loads (block#2556)
  fix(relay): give large roster and read-state reads a 30s deadline (block#2627)
  fix(user-status): show a status emoji's :name: on hover where the full status shows (block#2384)
  fix(inbox): keep the list's place when returning in the same session (block#2134)
  fix(messages): pass verified labels to the forward recipient picker (block#2633)
  feat(messages): forward a message to a person (block#2167)
  ...

# Conflicts:
#	tests/browser/settings.spec.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalvinnchau kalvinnchau kalvinnchau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wpfleger96 @kalvinnchau