[kalvinnchau]

Opening search (⌘T/⌘K) with an empty query now leads with unread channels and DMs and selects the first one, so ⌘T then Enter opens it.

Changes

• SearchResults: for the empty, unscoped All view, adds an Unread group ahead of This conversation and Recent activity.
  • Candidates use the existing Recent activity eligibility: joined or guest, not archived, not a sidebar-hidden DM, no huddles or pending metadata.
  • Unread state comes from the sidebar's useUnreadChannelIds / channelHasUnread signal: a manual mark, observed messages, or unread threads.
  • Confirmed-muted conversations are excluded, matching the Dock indicator and the sidebar's unread jump cues. The open conversation is excluded too.
  • Rows use the Recent activity order. The group shows up to six rows.
  • Recent activity omits every unread conversation, so no row appears twice.
  • highlightEmpty is set only while unread rows exist. With no unreads, the existing suggestions and unselected state are unchanged.
  • The highlight follows its row key, so an unread arriving while the picker is open does not redirect Enter.
• New device setting Show unread first in search (Settings → Appearance → Conversations, on by default; search.unread_first for agents). Off restores the previous empty search and reopen behavior.
• PageSearch: while the setting is on at reopen, an empty All view is not restored, so reopening reflects current unread state instead of restoring the last highlighted row. Remembered typed queries, the Channels tab, and scoped search are unchanged.
• docs/buzz-help.md: describes jumping to unread from search.

Tests

• SearchResults.test.tsx:
  • No unreads: no group, no selection, and Enter is inert.
  • Mixed unread channels and DMs.
  • Exclusion of the muted and the current conversation.
  • Group order and deduplication against Recent activity.
  • First-row selection, and a new unread above the selection not moving it.
  • Arrow and Enter navigation.
  • Typed queries unchanged.
• SearchResults.test.tsx: six-row cap, and overflow kept out of Recent activity; turning the setting off removes the group and selection.
• device-settings.test.ts: lists search.unread_first.
• ChannelDirectoryResults.test.tsx: an empty All view reopens fresh; with the setting off it reopens where it was left, and turning it back on reopens fresh.
• AppearanceSettings.test.tsx: the switch defaults on, saves, follows other windows, and retries a failed save.
• identity-names/consumers.test.tsx: its fake session gains the unread and sidebarPreferences capabilities that SearchResults now reads.

Both new behavior tests fail without the production change. No browser journeys were added. The existing global-search spec passes in Chromium and WebKit, and an actual-app ⌘T → Enter journey (production broker, modeled relay) was exercised in both engines.

🤖 Generated with Claude Code

[wesbillman]

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Requesting changes for two small user-facing issues in the empty-search Unread group, each in its inline thread. The rest holds up: eligibility matches Recent activity, mutes follow the sidebar's confirmed-only rule, the sidebarPreferences snapshot is reference-stable, and the highlight follows its channel: key, so a late unread does not redirect Enter.

Validation at e75504d: the three touched test files pass locally (174 tests). With SearchResults.tsx and PageSearch.tsx reverted to the merge base, the three new behavior tests fail as expected. Browser journeys (webkit, 10/14) failed on the first attempt and was pending a rerun when I checked; I did not verify the author's app journey.

To merge: fix the two inline findings and update the aria-setsize assertion. The help-doc note is optional.

[joahg]

🤖 Read SearchResults and PageSearch changes; muted and current-conversation exclusion, dedup against Recent activity, and the no-unread fallback all hold up. Browser webkit shard was still pending when I reviewed.

[kalvinnchau]

🤖 @wesbillman all three findings are addressed in c901f61. Unread rows no longer carry aria-setsize, Recent activity is omitted when Unread fills the list, and the help line is reworded. The aria-setsize assertion is updated, and there is a new assertion for the all-unread case. Each assertion fails with its fix reverted. CI is green on c901f61. Could you take another look?

addressed

[wesbillman]

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Re-review of e75504d..abb8d91: both earlier findings are fixed, and I found no new blockers. The Unread group no longer reports a set size it can't show, and Recent activity is left out when Unread fills the list. The new Show unread first in search setting follows the existing autocorrect-preference pattern, and reopen reads the preference at open time, so toggling it while search is closed takes effect. It fits in Appearance → Conversations.

Validation at abb8d91: the five touched test files pass locally (205 tests). Browser journeys were still running when I checked.

Two non-blocking notes are inline. The help-doc one comes from wording I suggested last round, sorry about that.