fix(json-schema): nested gen_id follows the property

src/JsonSchema/SchemaFactory.php

@@ -311,7 +311,7 @@ private function buildPropertySchema(Schema $schema, string $definitionName, str
                     continue;
                 }
 
-                $childSerializerContext = $serializerContext + [self::FORCE_SUBSCHEMA => true, 'gen_id' => $propertyMetadata->getGenId() ?? true];
+                $childSerializerContext = [self::FORCE_SUBSCHEMA => true, 'gen_id' => $propertyMetadata->getGenId() ?? ($serializerContext['gen_id'] ?? true)] + $serializerContext;
                 if (isset($serializerContext[AbstractNormalizer::ATTRIBUTES])) {
                     $attributes = $serializerContext[AbstractNormalizer::ATTRIBUTES];
                     if (\is_array($attributes) && \array_key_exists($normalizedPropertyName, $attributes) && \is_array($attributes[$normalizedPropertyName])) {

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainInverseMiddle.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/inverse_middles/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainInverseMiddle
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[ApiProperty(genId: false)]
+    #[Groups(['chain:read'])]
+    public ?GenIdChainLeaf $second = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainInverseRoot.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/inverse_roots/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainInverseRoot
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[ApiProperty(genId: true)]
+    #[Groups(['chain:read'])]
+    public ?GenIdChainInverseMiddle $first = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainLeaf.php

@@ -0,0 +1,41 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/leaves/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainLeaf
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[Groups(['chain:read'])]
+    public ?string $label = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainMiddle.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/middles/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainMiddle
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[ApiProperty(genId: true)]
+    #[Groups(['chain:read'])]
+    public ?GenIdChainLeaf $second = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainNullMiddle.php

@@ -0,0 +1,41 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/null_middles/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainNullMiddle
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[Groups(['chain:read'])]
+    public ?GenIdChainLeaf $second = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainNullRoot.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/null_roots/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainNullRoot
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[ApiProperty(genId: false)]
+    #[Groups(['chain:read'])]
+    public ?GenIdChainNullMiddle $first = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}

tests/Fixtures/TestBundle/ApiResource/JsonSchemaGenIdChain/GenIdChainRoot.php

@@ -0,0 +1,42 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <dunglas@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\ApiResource\JsonSchemaGenIdChain;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+use ApiPlatform\Metadata\Get;
+use Symfony\Component\Serializer\Attribute\Groups;
+
+#[ApiResource(operations: [
+    new Get(
+        uriTemplate: '/json_schema_gen_id_chain/roots/{id}',
+        normalizationContext: ['groups' => ['chain:read']],
+        provider: [self::class, 'provide'],
+    ),
+])]
+class GenIdChainRoot
+{
+    #[ApiProperty(identifier: true)]
+    #[Groups(['chain:read'])]
+    public ?int $id = null;
+
+    #[ApiProperty(genId: false)]
+    #[Groups(['chain:read'])]
+    public ?GenIdChainMiddle $first = null;
+
+    public static function provide(): ?self
+    {
+        return null;
+    }
+}