Repository navigation
fix(json-schema): nested gen_id follows the property - #8644
Merged
soyuka merged 1 commit intoOct 15, 2026
Merged
Conversation
The first relation's gen_id stuck to every deeper embedded definition, while the serializer lets each property's genId win and only inherits when it is null. Schemas then advertised `@id` (or not) differently from the payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SchemaFactorybuilt the child context as$serializerContext + ['gen_id' => …], so the first relation'sgen_idstuck to every deeper level. The serializer does the opposite (OperationContextTrait): the property's owngenIdwins and only anullinherits from the parent. Withroot → a (genId: false) → b (genId: true)the schema namedb_noidand usedHydraItemBaseSchemaWithoutIdwhile the payload carries@id, and the reverse chain had the mirror problem.The child context now uses
$propertyMetadata->getGenId() ?? ($serializerContext['gen_id'] ?? true).Found while mapping json-schema for symfony/symfony#64279, related to #8643.