Repository navigation
docs: Update SIPNET tutorials for Russell Ranch - #4192
tyagivibhor111-hub wants to merge 2 commits into
Conversation
|
Hey @dlebauer and @S1DDHEY, could you please review this PR when you have time? I've updated both Demo 1 and Demo 2 for the Russell Ranch example, added the SIPNET v2.2.0 climate and event inputs, and updated the configurations and notebook instructions for the 2016–2017 simulation period. I've also kept the shared downloader changes separate from Madhav's Part 1 PR #4189. If you notice any issues, have concerns about the approach, or think anything needs to be changed, please let me know. I'll address the feedback and make the necessary updates. |
S1DDHEY
left a comment
There was a problem hiding this comment.
The Russell Ranch climate and event inputs have been added, but both pecan.xml files still reference the existing temperate.coniferous prior distributions. Since #4184 says these priors should not be carried over, could we confirm the appropriate Russell Ranch teaching priors before merging?
@dlebauer @mdietze @infotroph @divine7022 , guidance on a suitable prior set would be appreciated.
|
I'll defer to @divine7022 for priors. re
Not strictly necessary but an alternative is to point this PR at the 4189 branch. Then this one can merge before or after the other one (if merged after, the target branch will automatically update to develop). |
Thanks, @dlebauer. I’ll wait for @divine7022’s guidance on the priors. |
|
Thanks for putting this together. I read through the diff ( and tested one thing against develop’s write.config.SIPNET(): 1.Site lat/lon: both pecan.xml files now have with only . Without lat/lon the generated job.sh contains the literal model2netcdf.SIPNET('…', @SITE_LAT@, @SITE_LON@, …) (with lat/lon given it expands to numbers), which isn’t valid R, so the output conversion step would fail when there is no database to fill them in. Adding / for Russell Ranch (from the SIPNET smoke-test inputs) should fix it. |
|
@dlebauer @infotroph @divine7022 Based on @madhavzanwar's review, I propose the following changes:
I think these changes will improve the reliability and clarity of both demos. |
Docs: Update SIPNET tutorials for Russell Ranch
Description
sipnet.clim) and event (events.in) input files to Demo 1.pecan.xmlconfigurations for the 2016–2017 simulation period and use the shared inputs in Demo 2.Motivation and Context
The existing tutorials use SIPNET v1.3.0 and the Niwot Ridge 2004 scenario. These changes update the examples to use the Russell Ranch inputs and SIPNET v2.2.0, keeping the two tutorial configurations consistent.
This PR covers Part 2 of #4184 and complements the shared downloader work in #4189.
Review Time Estimate
Types of changes
Checklist