Repository navigation
Conversation
download_sipnet.R now fetches the SIPNET v2.2.0 release tarball (Linux x86_64, macOS arm64) and both demo pecan.xml files set revision 2.2.0, which write.config.SIPNET needs to write a v2 config. Notebook text now names v2.2.0. Part 1 of PecanProject#4184 (downloader and revision; inputs and priors are left to Part 2).
5 tasks
Contributor
Author
3 of 14 tasks
S1DDHEY
suggested changes
Oct 25, 2026
S1DDHEY
left a comment
Contributor
There was a problem hiding this comment.
apart from a minor suggestion rest LGTM.
Stop with a clear error if extracting the release tarball does not produce demo_outdir/sipnet. Suggested in review. Part of PecanProject#4184
Contributor
Author
|
@S1DDHEY pushed the change, ready for another look when you have time. |
Contributor
Author
|
@dlebauer PecanProject/pecan#4189 (Part 1 of #4184: downloader and revision setting) is approved by @S1DDHEY and ready to merge when you have time. It doesn’t touch the site or priors, so it fits with the Niwot discussion. |
dlebauer
approved these changes
Nov 3, 2026
dlebauer
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks! I made a new branch 'sipnet-2-tutorial' so that we can merge all of the changes required for a working tutorial before merging into develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #4184, as agreed with @dlebauer (shared downloader and revision
setting). Priors, site and inputs (Part 2) are not touched.
What
download_sipnet.R: downloads the SIPNET v2.2.0 release tarball andextracts
sipnet. v2 releases ship tarballs only for Linux x86_64 andmacOS arm64; other systems get a clear error.
pecan.xmlfiles:<revision>2.2.0</revision>(wasgitand1.3.0). Without itwrite.config.SIPNETwrites a v1 config and SIPNETv2.2.0 aborts with "Did not find required parameter leafOnReallocFrac".
Testing
Ran the Demo 1 and Demo 2 notebook code from this branch with SIPNET v2.2.0
(Linux x86_64, R 4.3.3): both run end to end. I did not render the Quarto
notebooks or test the macOS download. The existing temperate.coniferous
priors still produce plant-mortality warnings with v2.2.0, as reported in
#4184; that is left for Part 2.