Repository navigation
Agent: give the Quit prompt the Editorial redesign - #1568
Draft
matthewrball wants to merge 1 commit into
Draft
matthewrball wants to merge 1 commit into
matthewrball wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Quit confirmation becomes the approved Editorial design:
ghost_button; "Quit Maple" / "Retry Quit" is the single accentprimary_buttonpill. The window keeps thekeep-maple-open/retry-maple-quittest selectors and the AccessKit-aware empty-frame close.Localization
The list grammar lives in Fluent so each locale controls its own commas and conjunctions:
native-quit-item-*phrase each item with CLDR plurals ({ $count } running { $count -> [one] task *[other] tasks }).native-quit-activityselects the join shape by$count(0–5) over$a…$e, so English gets the serial comma ("A, B, and C") while German and Spanish get "und"/"y" without it.native-quit-api-clause) interpolates as$api— empty when the listener is off, so "stops the host and waits" stays grammatical.native-stop-title/native-still-openkeys with new values, translated in de/es.Debug-only test loop
Debug builds (
cfg!(debug_assertions) && !cfg!(test)) confirm every Quit, and dismissing the prompt — Keep open, the close button, or ⌘W — brings it back after 400 ms, so the dialog can be exercised without live host activity. Release builds and the test suite keep today's behavior exactly; the existingfailed_tray_quit…test still passes unmodified.Design note for reviewers
The Quit pill uses the existing
primary_button(accent fill with the sharedon_accentlabel). The approved prototype rendered a dark label on coral; that divergence is intentionally not carried here, since restyling the token would touch every primary action. If the WCAG direction (default_buttonmigration) should apply to this dialog too, that's a one-line swap.Test plan
quit_prompt_body_lists_live_work_in_one_sentence— full list with the API clause, API-only, idle host, and the two-item join without the serial comma.desktop.rs, and thefailed_tray_quit…window test.just cilocally (fmt, clippy across feature sets, workspace tests).Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.