镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Sparkle updates - #759

Merged
austincondiff merged 19 commits into
CodeEditApp:mainfrom
austincondiff:sparkle-updates
Sep 27, 2022
Merged

Sparkle updates#759
austincondiff merged 19 commits into
CodeEditApp:mainfrom
austincondiff:sparkle-updates

Conversation

@austincondiff

@austincondiff austincondiff commented Sep 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Adds update capabilities to the application menu and application preferences.

Related Issue

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

image

image

austincondiff and others added 3 commits September 16, 2022 22:31
@austincondiff @Matejkob
Split Layouts WIP (#702)
4e95209 
* [#338] Add `SplitEditors` and `SplitEditorsTests` targets; Add drop delegate, calculations of proposal position and unit tests to it

* Add split editor drop proposal overlay

* Create overlay as on the mock-ups

* Add possibility to chose available positions

* Rename Split Editor to Split View

* Add split view view modifier

* Add possibility to handle end of dragging

Co-authored-by: Mateusz Bąk <44930823+Matejkob@users.noreply.github.com>
@austincondiff
Added update capabilities to application menu and preferences.
9088307
@austincondiff
Fixed typos
7a114f5
@austincondiff

austincondiff commented Sep 18, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks to @MattKiazyk for showing me what he did in Xcodes.

This is not working yet. It is pointing to currently non-existent appcast xml files. We need to create a GitHub action to generate these files and host them on GitHub pages.

@austincondiff
austincondiff marked this pull request as draft September 18, 2022 05:40
0xWDG
0xWDG previously approved these changes Sep 18, 2022
View reviewed changes
thecoolwinter
thecoolwinter previously requested changes Sep 18, 2022
View reviewed changes
Comment thread CodeEdit/Info.plist
@austincondiff
Moved updater state object up so it will get initialized on launch an…
f314a34 
…d added SUEnableInstallerLauncherService to Info.plist
@austincondiff
austincondiff requested review from 0xWDG, MattKiazyk and thecoolwinter and removed request for MattKiazyk September 19, 2022 18:39
@austincondiff austincondiff changed the title [WIP] - Sparkle updates Sparkle updates Sep 19, 2022
@austincondiff
austincondiff marked this pull request as ready for review September 19, 2022 18:41
MattKiazyk
MattKiazyk reviewed Sep 19, 2022
View reviewed changes
Comment thread CodeEditModules/Modules/AppPreferences/src/SoftwareUpdater.swift Outdated
@austincondiff

austincondiff commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Is this going to be a problem? Is there a better way to handle this?

image

...

image

@MattKiazyk

MattKiazyk commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

@austincondiff I think it's doing that because you are using a @StateObject inside AppKit where it doesn't really belong. Removing @StateObject makes it work.

Secondly - don't think you need a shared singleton since you're passing the object up into preferences view.

@austincondiff

austincondiff commented Sep 23, 2022

Copy link
Copy Markdown
Collaborator Author

@MattKiazyk I think you are right. There is only one Preferences window and AppDelegate is only initialized once. Changes made.

@austincondiff

austincondiff commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@MattKiazyk @thecoolwinter @lukepistrol Can this be merged? Is there anything else that needs to be done here?

@austincondiff
austincondiff requested review from MattKiazyk and lukepistrol and removed request for MattKiazyk September 26, 2022 17:23
thecoolwinter
thecoolwinter approved these changes Sep 26, 2022
View reviewed changes

@thecoolwinter thecoolwinter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthijseikelenboom

matthijseikelenboom commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

The only criticism I have is the lack of spacing in CodeEditModules/Modules/AppPreferences/src/SoftwareUpdater.swift

Other than that, it can be merged

@austincondiff
austincondiff merged commit 92d4bf7 into CodeEditApp:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes
@0xWDG 0xWDG Awaiting requested review from 0xWDG
@lukepistrol lukepistrol Awaiting requested review from lukepistrol
@MattKiazyk MattKiazyk Awaiting requested review from MattKiazyk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@austincondiff @MattKiazyk @matthijseikelenboom @0xWDG @thecoolwinter