镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

✨ Split Editors #338

Description

@austincondiff

Is your feature request related to a problem? Please describe.

Users might want to see more than one editor at once.

Describe the solution you'd like

We need the ability to open editors in a split side-by-side layout, vertically and horizontally.

Mockups

Step 1: User mouses over to editor tab that they would like to go in a new split editor

image

Step 2: User drags tab out of the tab bar

To the bottom half of the editor to split down

image

Or to the right half of the editor to split right

image

Step 3: User releases mouse and new split editor view is added to the right

image

Step 4: User drags addition tab to right split editor view

To add it to the existing split view, the user can drag the tab into the tab bar of the right split or over the center of the split view like so...

image

To split the right split view again to the right...

image

Note: This will create three columns equal in width. Dragging to the right side of the left split and the left side of the right split will do the same thing, create a new split view in the middle of the two existing split views.

Or to the bottom to create a bottom split within the existing right split...

image

Describe alternatives you've considered
n/a

Additional context

See Workspace Windowing & Layout Strategy.

Notice the close editor button on the left and split icon on the right. When right clicking this split icon you might see an option to split vertically as well. We might have an icon that puts that pane in fullscreen like Xcode
Screen Shot 2022-03-30 at 11 41 56 AM

We may also consider a setting that closes the editor pane on close of the last tab in that pane.

Screen Shot 2022-03-30 at 11 41 56 AM

VSCode Split Editors
Screen Shot 2022-03-30 at 12 10 00 PM

Complex layouts are possible
image

Related Issues

Activity

  1. changed the title [-][FEAT] - Split Editors[/-] [+]✨ Split Editors[/+] on Mar 31, 2022
  2. austincondiff commented on May 16, 2022

    @austincondiff
    CollaboratorAuthor

    Please note, this issue is blocked and is dependent on the completion of the following issue:

  3. Matejkob commented on Jul 3, 2022

    @Matejkob
    Contributor

    I can try to do it. 🚀

  4. added a commit that references this issue on Jul 3, 2022
  5. Matejkob commented on Jul 3, 2022

    @Matejkob
    Contributor

    I noticed that on the mockups when a user drags the tab out and puts it in the editor, it splits the editor and placeholder into two independent views. We can handle it in a bit different way - in the same way, as VS code handles this. Instead of creating two independent views embedded into VStack or HStack, we can create an overlay above the editor. Moreover, we can go a bit further behind VS code idea and let a user option to put a new editor in one of the following positions: leading, trailing, top, bottom or center. Position center probably isn't required when a user drags the tab out of the tab bar, but if we add dragging a file out directly from the navigator, it would be necessary. Thanks to this solution interface would be a bit more user-friendly and a bit more smooth during choosing positions for the new editor. I'm attaching the recording with POC.

    Screen.Recording.2022-07-03.at.7.14.47.PM.mov
  6. added a commit that references this issue on Jul 30, 2022
  7. added a commit that references this issue on Sep 27, 2022
  8. moved this from Todo to In Progress in CodeEdit Projecton Sep 29, 2022
  9. andyPark commented on Oct 3, 2022

    @andyPark

    I'm actively working on this, could you assign it to me? @austincondiff

  10. 2 remaining items

  11. removed their assignment
    on Nov 5, 2022
  12. andyPark commented on Nov 5, 2022

    @andyPark

    @austincondiff Hey I got dragged into another project, sorry but I can't finish this task at the moment!

  13. austincondiff commented on Nov 5, 2022

    @austincondiff
    CollaboratorAuthor

    No worries. Anybody else care to take this on?

  14. austincondiff commented on Dec 14, 2022

    @austincondiff
    CollaboratorAuthor

    I just updated the mockups in main issue description. Per @Matejkob's comment:

    I noticed that on the mockups when a user drags the tab out and puts it in the editor, it splits the editor and placeholder into two independent views. We can handle it in a bit different way - in the same way, as VS code handles this. Instead of creating two independent views embedded into VStack or HStack, we can create an overlay above the editor.

    These updated mockups reflect this by floating the placeholders on top of the editor view instead of splitting the view as the user is dragging as this could lead to a frustrating UX.

  15. austincondiff commented on Dec 14, 2022

    @austincondiff
    CollaboratorAuthor

    I am assigning this to @bombardier200. @Matejkob could you brief him on the work you started?

  16. moved this from 🏃‍♂️ In Progress to 👀 In Review in CodeEdit Projecton Mar 5, 2023
  17. linked a pull request that will close this issueSplitview #1080on Mar 5, 2023
  18. moved this from 👀 In Review to 🏁 Complete in CodeEdit Projecton Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions