You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tests: update structuredClone nesting oracle for DOMException #80
Introduced by c45232db (feat(dom): add DOMException; structuredClone throws DataCloneError).
Linux CI unit shard 3 now deterministically fails structured clone nesting limit is catchable because the test still requires e instanceof TypeError, while the new and intended platform behavior is a DOMException with name === "DataCloneError".
Fixed on main in 52f41b38 (test(clone): expect nesting DOMException (#80)). The nesting-limit witness now asserts the intended new platform contract: catchable DOMException, name === "DataCloneError", and code === DOMException.DATA_CLONE_ERR. Exact focused validation passed 2/2 with zero leaks; no production structured-clone behavior changed.
Reopened: the current main run exposed a second stale oracle in the broad structuredClone unit test. Linux unit shard 1 still checks that cloning a function throws TypeError, while c45232d correctly changed that failure to a DataCloneError DOMException. I am updating the broad oracle to assert DOMException, name, and legacy code before pushing the focused follow-up.
Follow-up pushed to main as e78ae6c. It updates the remaining broad structuredClone function-rejection oracle to require DOMException, name === DataCloneError, and code === DOMException.DATA_CLONE_ERR. Focused result: 2/2 passed, 0 leaked. New main CI: https://github.com/zig-utils/zig-js/actions/runs/29340551356
Activity
test(clone): expect nesting DOMException (#80)
chrisbbreuer commentedon Jul 14, 2026
Fixed on
mainin52f41b38(test(clone): expect nesting DOMException (#80)). The nesting-limit witness now asserts the intended new platform contract: catchableDOMException,name === "DataCloneError", andcode === DOMException.DATA_CLONE_ERR. Exact focused validation passed 2/2 with zero leaks; no production structured-clone behavior changed.chrisbbreuer commentedon Jul 14, 2026
Combined replacement CI: https://github.com/zig-utils/zig-js/actions/runs/29338741409
chrisbbreuer commentedon Jul 14, 2026
Reopened: the current main run exposed a second stale oracle in the broad structuredClone unit test. Linux unit shard 1 still checks that cloning a function throws TypeError, while c45232d correctly changed that failure to a DataCloneError DOMException. I am updating the broad oracle to assert DOMException, name, and legacy code before pushing the focused follow-up.
test(clone): update function rejection oracle (#80)
chrisbbreuer commentedon Jul 14, 2026
Follow-up pushed to main as e78ae6c. It updates the remaining broad structuredClone function-rejection oracle to require DOMException, name === DataCloneError, and code === DOMException.DATA_CLONE_ERR. Focused result: 2/2 passed, 0 leaked. New main CI: https://github.com/zig-utils/zig-js/actions/runs/29340551356
chrisbbreuer commentedon Jul 14, 2026
Correction to the run link in the previous comment: the CI run for e78ae6c is https://github.com/zig-utils/zig-js/actions/runs/29339154198 (currently queued).