Repository navigation
Description
Parent: #480. Blocks stacksjs/the-settlers-iii-remake#244. Related: #1115 and #1120.
A public Object.fromEntries regression now executes red on the current combined engine candidate. A key's Symbol.toPrimitive callback crosses the maintained moving-GC checkpoint before returning the numeric string "1". The entry value is a retained object. The engine aborts in writeBarrierFromManaged, asserting child.magic == header_magic, when objectFromEntries stores its stale value after key conversion.
The case uses the existing expectProxyMetadataMoving seam, which requires actual relocation and checks both tree-walker and required-bytecode modes. The red source is engine 93b7cc4 plus integrated source diff a793a7447a8e20d19397d3a36fbfcc2f6ae61e027efe266a22fd9281f7468e0c and the new regression. The original failure log, command, binary and first candidate are retained under Verification/settlers-retained-replay/native-growth-audit/managed-frames-integration/enumeration-roots.
objectFromEntries currently keeps its partially constructed result, iterator, captured next method, step result, entry, key and value as raw native Values across arbitrary iterator/getter/key-coercion calls. Give these continued operands authoritative temporary roots, refresh after callbacks, and keep copied key bytes alive through property creation. Retire step roots and scratch per iteration. Preserve the distinction between IteratorStep failures and adder failures, exact coercion order, symbols, Unicode/NUL keys, and CreateDataProperty semantics.
This defect was found while diagnosing a full native replay discrepancy. The original simulation and checkpoint match the browser, while one characterized canonical serialization omits ledger key "1"; its full state and stored chunk hashes still match the independent oracle. The unchanged latest combined consumer still reports replay divergence at callback 5,148. The moving-key crash is an independently executed source defect, not yet proof of the sole cause of replay divergence.
Acceptance:
- Retain the executed moving-key regression and make it pass without pinning, collection suppression or application changes.
- Preserve result/iterator/step/entry/key/value identities through moving callbacks at their relevant public boundaries.
- Retain exact key-coercion order and iterator-closing behavior, including abrupt completions, symbols and arbitrary string keys.
- Pass affected canonical units, conformance, allocation-failure and instrumented checks with actual denominators.
- Rerun the unchanged full 5,000-tick native checkpoint/replay consumer at 64 MiB and the default guard, retaining its real outcome before claiming adoption.
Activity
chrisbbreuer commentedon Nov 10, 2026
The retained moving-key regression aborts on the prior candidate in
writeBarrierFromManaged(child.magic == header_magic). The source fix roots continued operands, refreshes them after callbacks and retires per-entry roots and scratch.Focused Debug qualification now passes 4/4 selected test blocks, with zero skips, failures or leaks. Three are the new
Object.fromEntries movingregressions; the fourth is the linked JIT fixture. Each moving regression uses the maintained helper in both tree-walker and required-bytecode modes and requires an actual moving collection and changed subject address. Coverage includes the iterator getter, next getter/call, done/value getters, entry getters, key coercion, symbols, surrogate/NUL/Unicode string keys, and preserving the original exception when iterator closing also throws.The unchanged full native consumer was also rebuilt in ReleaseSafe against this exact candidate and rerun at 64 MiB, the default guard and without explicit collection. Initial simulation and restored checkpoint still match
b413c661, but replay fails at callback 5,119: tick 116 expects0d77d36dand reportscad9d071. This source correction therefore does not establish full replay acceptance. Full canonical units and further qualification remain in progress. No native package adoption or completion is claimed.Retained candidate: engine parent
93b7cc498ffa1f84134e456bdf4c0075dff2abbd, tracked diff SHA-256b966411db4de3d99f7b739987b3504438658292a98b29319ff2835459c03e9f4; original consumer bundle SHA-2560935723acdd8bc2007c991757bb13e7be04df23251aea97ad307c179cc4c5d31. Commands, red/green binaries, logs and consumer receipt are underVerification/settlers-retained-replay/native-growth-audit/managed-frames-integration/enumeration-rootsandgame-release-safe-from-entries-roots.fix(object): root fromEntries operands across callbacks
chrisbbreuer commentedon Nov 10, 2026
Pushed 8002da3b. Continued fromEntries operands and exact key bytes are now rooted/owned across callbacks. The executed moving-key crash regression and iterator/getter/symbol/Unicode/abrupt cases pass. All 6 selected tests, including exhaustive allocation failures in arena and precise modes, pass in Debug, ReleaseSafe and all-module ThreadSanitizer without suppressions.
The combined production candidate passed 2,872 full-suite tests with one skip and zero failures/leaks locally. Before/after conformance passes 6,031 cases in both binaries across 39 affected subtrees, with no regressions. Home ABI fixtures pass in Debug, ReleaseSafe and instrumented TSan. Exact commands, source/binary hashes and logs are retained in
Verification/settlers-retained-replay/native-growth-audit/managed-frames-integration; final delivery source equivalence is recorded indelivery-qualified-source.json.Hosted CI on the pushed head still has real failures in cleanup, threaded OOM, the own-key allocation fixture and benchmark metadata contracts. The validator and fixture follow-ups are being qualified separately. The unchanged full native game consumer still diverges at callback 5,119 despite matching simulation and checkpoint checksums. That independent discrepancy is now #1122. No complete engine release, downstream adoption, native presentation, or full replay acceptance is claimed.