Binding SelectedItems crash #56

Activity

1. CBenghi commented on Dec 10, 2021

   

   CBenghi

   on Dec 10, 2021

   Author

   More actions

   I've looked at the code and I think the problem lies with the initialization of the SelectedItems property.

   It is initialized at the following lines in the constuctor:

   MultiSelectTreeView/MultiSelectTreeView/Controls/MultiSelectTreeView.cs

   Lines 89 to 91 in 8dadce5

   	public MultiSelectTreeView()
   	{
   	SelectedItems = new ObservableCollection<object>();

   whereas it should be initialized in the metadata of the DependencyProperty with something like the following:

   public static DependencyProperty SelectedItemsProperty = DependencyProperty.Register(
   	"SelectedItems",
   	typeof(IList),
   	typeof(MultiSelectTreeView),
   	new FrameworkPropertyMetadata(
   		new ObservableCollection<object>(), 
   		FrameworkPropertyMetadataOptions.BindsTwoWayByDefault, 
   		OnSelectedItemsPropertyChanged)
   	);

   I'm happy to post a PR if this solution works for you.
2. ygoe commented on Dec 11, 2021

   

   ygoe

   on Dec 11, 2021

   Owner

   More actions

   I think I've never done that. My approach was to bind each item's IsSelected property (this is prone to missed notifications while items are virtualised away) or do the selection stuff in the view code (.xaml.cs) instead. I'm not using this code anymore and I can't offer much support for it now.