镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

The regExp of IS_PURE_FUNCTION & IS_ARROW_FUNCTION seem to be extra??? #147

Closed as not planned

Description

@zhtyytg

source code :

var IS_PURE_FUNCTION = /function.?(/;
var IS_ARROW_FUNCTION = /.
?=>.*?/;

// pure functions, example: {key: function() {}}
if(IS_PURE_FUNCTION.test(serializedFn)) {
return serializedFn;
}

// arrow functions, example: arg1 => arg1+5
if(IS_ARROW_FUNCTION.test(serializedFn)) {
return serializedFn;
}

Q:
when I use serialize like:
{
name: "aa",
attrname: "bb",
render(item, row) {
return JSON.parse(item) .map((it) => it.name).join("");
},
}

the regExp will catch this and cause problem, not when it's commented.
then I test the normal way like this:
{
name: "aa",
attrname: "bb",
render: (item, row) => {
return JSON.parse(item) .map((it) => it.name).join("");
},
}

and:

{
name: "aa",
attrname: "bb",
render: function(item, row) {
return JSON.parse(item) .map((it) => it.name).join("");
},
}

without the regExps, these are also correct.

could you please explain me?

Activity

  1. redonkulus commented on Oct 22, 2026

    @redonkulus
    Collaborator

    Duplicate of #118: method detection matches nested function/=> anywhere in the source instead of only the outer signature. That's being addressed in #231. Closing in favor of #118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions