镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: add prefix for invalidate endpoint - #2571

Merged
hiroppy merged 1 commit into
webpack:v4from
EslamHiko:invalidate-prefix
May 8, 2020
Merged

hiroppy merged 1 commit into
webpack:v4from
EslamHiko:invalidate-prefix

Conversation

@EslamHiko

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

as @sokra suggested : #2493 (review)

Breaking Changes

a change in the endpoint from /invalidate to /webpack-dev-server/invalidate.

Additional Info

@codecov

codecov Bot commented May 5, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #2571 into v4 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2571   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          35       35           
  Lines        1313     1313           
  Branches      368      368           
=======================================
  Hits         1219     1219           
  Misses         89       89           
  Partials        5        5           
Impacted Files Coverage Δ
lib/utils/routes.js 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768ced4...5d2ce25. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes May 6, 2020

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiroppy
hiroppy previously approved these changes May 6, 2020

@hiroppy hiroppy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change so it's better to change the branch to v4.

@EslamHiko
EslamHiko dismissed stale reviews from hiroppy and alexander-akait via 07ad1be May 7, 2020 08:20
@EslamHiko
EslamHiko force-pushed the invalidate-prefix branch from 8ed9f74 to 07ad1be Compare May 7, 2020 08:20
@EslamHiko
EslamHiko changed the base branch from master to v4 May 7, 2020 08:22
@EslamHiko

Copy link
Copy Markdown
Contributor Author

/cc @evilebottnawi @Loonride @hiroppy

@hiroppy

hiroppy commented May 7, 2020

Copy link
Copy Markdown
Contributor

CI fails

hiroppy
hiroppy previously approved these changes May 8, 2020
@hiroppy
hiroppy dismissed their stale review May 8, 2020 08:45

CI fails

@alexander-akait

Copy link
Copy Markdown
Member

@hiroppy I think it is due regression with output

@alexander-akait

Copy link
Copy Markdown
Member

@EslamHiko can you rebase?

@EslamHiko
EslamHiko force-pushed the invalidate-prefix branch from 07ad1be to 5d2ce25 Compare May 8, 2020 11:12
@EslamHiko

Copy link
Copy Markdown
Contributor Author

@evilebottnawi CI is green 😄

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @hiroppy

@hiroppy
hiroppy merged commit 674d926 into webpack:v4 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants