镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Emit progress-update event on the listeningApp, allowing update progress to be obtained in the node API. - #1666

Closed
pfdgithub wants to merge 3 commits into
webpack:masterfrom
pfdgithub:progress-update-in-node-api
Closed

pfdgithub wants to merge 3 commits into
webpack:masterfrom
pfdgithub:progress-update-in-node-api

Conversation

@pfdgithub

Copy link
Copy Markdown
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

Just like in the browser, we can now get the compilation progress of the current project in the node API.

new webpackDevServer(webpack, config).listen(port, hostname, function (err) {
  this.on('progress-update', ({ percent, msg }) => {
    console.log(`${percent}% - ${msg}.`);
  });
});

…ess to be obtained in the node API.

```
new webpackDevServer(webpack, config).listen(port, hostname, function (err) {
  this.on('progress-update', ({ percent, msg }) => {
    console.log(`${percent}% - ${msg}.`);
  });
});
```
@jsf-clabot

jsf-clabot commented Feb 15, 2019 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@alexander-akait alexander-akait left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept CLA and add tests

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept CLA and add tests

@pfdgithub
pfdgithub requested a review from hiroppy as a code owner February 25, 2019 03:07
@codecov

codecov Bot commented Feb 25, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #1666 into master will decrease coverage by 0.32%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
- Coverage   84.39%   84.06%   -0.33%     
==========================================
  Files           7        7              
  Lines         519      521       +2     
  Branches      159      160       +1     
==========================================
  Hits          438      438              
- Misses         64       65       +1     
- Partials       17       18       +1
Impacted Files Coverage Δ
lib/Server.js 79.52% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf99c26...ee98dc3. Read the comment docs.

@alexander-akait

Copy link
Copy Markdown
Member

Please accept CLA

@hiroppy

hiroppy commented May 30, 2019

Copy link
Copy Markdown
Contributor

Friendly ping @pfdgithub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants