Repository navigation
feat(cli): report auth_url in context, time waits, and list items one per line - #19
Merged
Merged
Conversation
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 9, 2026 18:03
71de33b to
266af4b
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 13, 2026 18:56
266af4b to
6a7900c
Compare
thebrandonlucas
marked this pull request as ready for review
October 13, 2026 18:56
This was referenced Oct 13, 2026
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
3 times, most recently
from
October 19, 2026 13:47
d0e7694 to
979d77b
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
2 times, most recently
from
October 19, 2026 18:39
33b3ff1 to
aaccd91
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 19, 2026 18:47
aaccd91 to
12dd969
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 19, 2026 19:11
12dd969 to
d0081bc
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 19, 2026 19:19
d0081bc to
0731c2f
Compare
This was referenced Oct 19, 2026
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 20, 2026 00:20
0731c2f to
7000252
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 20, 2026 11:59
7000252 to
246a16f
Compare
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 20, 2026 12:25
246a16f to
67f79c3
Compare
tee8z
self-requested a review
October 20, 2026 12:33
tee8z
reviewed
Oct 20, 2026
tee8z
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The robot has two small comments, both about --auth-url:
- The new
auth_url_mismatchhint suggests avoltage loginthat always fails, because the name is already saved. - For a saved API key,
voltage contextreports an auth URL that nothing uses, and labels its sourceflagwhen no--auth-urlwas passed.
Each comment has a suggestion. The robot built the branch and checked both against the binary.
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 20, 2026 13:01
67f79c3 to
c42a8c7
Compare
tee8z
self-requested a review
October 20, 2026 14:22
tee8z
requested changes
Oct 20, 2026
tee8z
left a comment
Contributor
There was a problem hiding this comment.
The two --auth-url comments from the last round still apply at c42a8c7. They look like they were missed in the restack after #24. I replied on each thread with what is still there:
- The
auth_url_mismatchhint (src/config.rs:149) still suggests avoltage loginthatloginrefuses for a saved name. voltage contextstill reports a saved API key'sauth_url(src/context.rs:145), andtests/cli_integration.rs:919now asserts it.
Everything else looks good. The robot ran the CRAP report on c42a8c7: no function at or above 20, highest api::wait_for_payment at 19.24, which matches the description. The full test suite passed in the same run.
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 20, 2026 15:17
c42a8c7 to
aa9dae4
Compare
… per line Each item of a string list now gets its own line in human output, aligned with the value column, so a dry run's notes no longer run together. An empty list shows as -. voltage context reports auth_url beside api_url: for a saved browser login, the URL it was saved with (sourced like the credential), else the normalized --auth-url flag, else the built-in default. A --auth-url that differs from a saved login's URL is the credential problem auth_url_mismatch, which context reports and commands reject (exit 2) with a hint to omit the flag or sign in at the new URL. Payment waits and device approval show how long they have waited, such as "Waiting for the payment to be completed... 1m 05s", so a status line on a slow wait does not look stuck. Progress keeps its #[must_use].
thebrandonlucas
force-pushed
the
feat/cli-ux-followups
branch
from
October 20, 2026 15:32
aa9dae4 to
eeed075
Compare
tee8z
self-requested a review
October 20, 2026 15:43
tee8z
approved these changes
Oct 20, 2026
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: master ← #24 ← #19 ← #26 ← #27 ← #28 ← #29 ← #30 ← #55 ← #59. #20, #22 and #57 are merged.
-, for local and API results.voltage contextshowsauth_urlbesideapi_url. For a saved browser login it is the URL the login was saved with, sourced like the credential. Otherwise it is the--auth-urlflag, normalized as commands normalize it, or the built-in default.auth_url_mismatch: a--auth-urlthat differs from a saved login's URL is a new credential problem.voltage contextreports it, and commands still refuse with exit 2 ("Saved credentials cannot be refreshed at a different auth URL"), now with a hint: omit--auth-url, or sign in at the new URL withvoltage login --account NAME --auth-url URL. Before, context showed the flag as if it would be used.Waiting for the payment to be completed... 1m 05s, so a slow wait does not look stuck.Changes after review
Progresshas its doc comment and#[must_use]again. They had moved onto the newelapsedfunction, so dropping a progress guard by mistake no longer warned.auth::resolveintoauth::select, which commands andvoltage contextboth use.auth_urldefault, flag, and saved sources; flag normalization; the mismatch in context and in a command; an invalid--auth-url; the device-approval elapsed label; and an empty API string list rendering as-.Checks
On
eeed075:cargo fmt --check,cargo clippy --locked --all-targets -- -D warnings,cargo machete --with-metadata: pass.cargo test --locked: 98 unit and 85 integration tests pass.VOLTAGE_BLESS=1 cargo test --lockedleaves the tree clean.python3 scripts/check-coverage.py: pass.scripts/crap-report.sh): no function at or above 20. Highest isapi::wait_for_paymentat 19.24, unchanged from or lower than master (19.66).voltage-pr-reviewand thevoltage-backend-engineeringRust checklist, against the stack base. Findings are fixed in this commit.Not run: the staging and live tutorials, which need credentials.