镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Revisit layering and definition of struct clockcache_entry{}, and possibly of struct clockcache{} #273

Open

Description

@gapisback

This issue was raised and discussed during reviews of PR #230 . Currently we have the following structures defined in clockccahe.h and the status flags for clockcache_entry{}->status defined in clockcache.c file

  • struct clockcache_entry{}
  • struct clockcache{}

The former certainly should be relocated to the .c file, so that there is no risk of other modules diddling with this structure.

Investigate if it's possible to also define clockcache{} in the .c file and leave an opaque reference to in the .h file. This will entail some rework in the places where this structure is stack-allocated to go through malloc, and some things to be done differently to init v/s create this structure when needed. Figure out how much of this rework is possible for the 2nd structure.

Activity

  1. self-assigned this
    on Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions